Bug 166781

Summary: Add infrastructure for sending autoplay website policies to WebKit
Product: WebKit Reporter: Matt Rajca <mrajca>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Matt Rajca
Reported 2017-01-06 15:16:49 PST
This tracks adding infrastructure for sending autoplay website policies to WebKit.
Attachments
Patch (7.25 KB, patch)
2017-01-06 15:25 PST, Matt Rajca 		no flags
DetailsFormatted DiffDiff
Patch (7.84 KB, patch)
2017-01-06 16:18 PST, Matt Rajca 		no flags
DetailsFormatted DiffDiff
Patch (7.81 KB, patch)
2017-01-06 16:29 PST, Matt Rajca 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Matt Rajca
Comment 1 2017-01-06 15:25:32 PST
Created attachment 298233 [details] Patch
Alex Christensen
Comment 2 2017-01-06 15:33:49 PST
Comment on attachment 298233 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298233&action=review api doesn't affect behavior yet. > Source/WebKit2/Shared/WebsitePolicies.h:49 > + encoder << autoplayPolicy; Can we use encodeEnum instead of typedefing to an integer?
Matt Rajca
Comment 3 2017-01-06 16:10:00 PST
(In reply to comment #2) > Comment on attachment 298233 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=298233&action=review > > api doesn't affect behavior yet. > > > Source/WebKit2/Shared/WebsitePolicies.h:49 > > + encoder << autoplayPolicy; > > Can we use encodeEnum instead of typedefing to an integer? Done.
Matt Rajca
Comment 4 2017-01-06 16:18:30 PST
Created attachment 298235 [details] Patch
Matt Rajca
Comment 5 2017-01-06 16:29:42 PST
Created attachment 298236 [details] Patch
WebKit Commit Bot
Comment 6 2017-01-06 17:07:23 PST
Comment on attachment 298236 [details] Patch Clearing flags on attachment: 298236 Committed r210461: <http://trac.webkit.org/changeset/210461>
WebKit Commit Bot
Comment 7 2017-01-06 17:07:26 PST
All reviewed patches have been landed. Closing bug.
Daniel Bates
Comment 8 2017-01-06 23:37:16 PST
(In reply to comment #6) > Comment on attachment 298236 [details] > Patch > > Clearing flags on attachment: 298236 > > Committed r210461: <http://trac.webkit.org/changeset/210461> This broke the EFL port: [[ FAILED: [...] ../../Source/WebKit2/UIProcess/API/C/WKWebsitePolicies.cpp ../../Source/WebKit2/UIProcess/API/C/WKWebsitePolicies.cpp: In function ‘WKWebsiteAutoplayPolicy WKWebsitePoliciesGetAutoplayPolicy(WKWebsitePoliciesRef)’: ../../Source/WebKit2/UIProcess/API/C/WKWebsitePolicies.cpp:65:1: error: control reaches end of non-void function [-Werror=return-type] } ]] <https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/31194/steps/compile-webkit/logs/stdio>
Daniel Bates
Comment 9 2017-01-06 23:44:14 PST
(In reply to comment #8) > (In reply to comment #6) > > Comment on attachment 298236 [details] > > Patch > > > > Clearing flags on attachment: 298236 > > > > Committed r210461: <http://trac.webkit.org/changeset/210461> > > This broke the EFL port: > [[ > FAILED: [...] ../../Source/WebKit2/UIProcess/API/C/WKWebsitePolicies.cpp > ../../Source/WebKit2/UIProcess/API/C/WKWebsitePolicies.cpp: In function > ‘WKWebsiteAutoplayPolicy > WKWebsitePoliciesGetAutoplayPolicy(WKWebsitePoliciesRef)’: > ../../Source/WebKit2/UIProcess/API/C/WKWebsitePolicies.cpp:65:1: error: > control reaches end of non-void function [-Werror=return-type] > } > ]] > <https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/ > builds/31194/steps/compile-webkit/logs/stdio> Committed attempt to fix the build in <http://trac.webkit.org/changeset/210475>.
Note You need to log in before you can comment on or make changes to this bug.