Summary: | ASSERTION FAILED: !m_isPointerLocked in WebKit::WebPageProxy::requestPointerLock() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||||
Component: | New Bugs | Assignee: | Jeremy Jones <jeremyj-wk> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, jeremyj-wk, jonlee, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=166656 | ||||||||
Attachments: |
|
Description
Ryan Haddad
2017-01-06 09:02:39 PST
Seen with these LayoutTests: http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock.html http/tests/pointer-lock/pointerlockelement-same-origin.html pointer-lock/lock-lost-on-alert.html Marked the affected tests as crashing on mac-wk2 debug in http://trac.webkit.org/projects/webkit/changeset/210441 (In reply to comment #3) > Marked the affected tests as crashing on mac-wk2 debug in > http://trac.webkit.org/projects/webkit/changeset/210441 Switched the expectation to skip in https://trac.webkit.org/changeset/210937 since they show up in every run. Skipping those tests seems to have caused two more to assert: http/tests/pointer-lock/pointerlockelement-different-origin.html pointer-lock/lock-lost-on-esc-in-fullscreen.html https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r210939%20(10480)/results.html After much trying, I was unable to find a single test that seemed to be causing the crashes. When I skipped all but two, the second one would frequently crash. It seems like this could be due to some state not being reset between tests. I skipped all pointer-lock tests on mac-wk2 in https://trac.webkit.org/changeset/210975 *** Bug 167445 has been marked as a duplicate of this bug. *** Created attachment 299821 [details]
Patch
Rebase please. Created attachment 299839 [details]
Patch
(In reply to comment #9) > Rebase please. Done. Comment on attachment 299839 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299839&action=review > Source/WebKit2/ChangeLog:9 > + When the main frame is load is committed, pointer lock should end. > + This resets pointer lock state between tests and allows tests to succeed. What about process crash? (In reply to comment #12) > Comment on attachment 299839 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=299839&action=review > > > Source/WebKit2/ChangeLog:9 > > + When the main frame is load is committed, pointer lock should end. > > + This resets pointer lock state between tests and allows tests to succeed. > > What about process crash? Process crash and going into page cache are fixed here: https://bugs.webkit.org/show_bug.cgi?id=165425 Comment on attachment 299839 [details] Patch Clearing flags on attachment: 299839 Committed r211234: <http://trac.webkit.org/changeset/211234> All reviewed patches have been landed. Closing bug. |