Bug 166742

Summary: AutomaticThread timeout shutdown leaves a small window where notify() would think that the thread is still running
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: Web Template FrameworkAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2017-01-05 14:17:09 PST
Patch forthcoming.
Attachments
the patch (8.07 KB, patch)
2017-01-05 14:22 PST, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-01-05 14:22:08 PST
Created attachment 298133 [details] the patch
WebKit Commit Bot
Comment 2 2017-01-05 14:24:31 PST
Attachment 298133 [details] did not pass style-queue: ERROR: Source/WTF/wtf/AutomaticThread.cpp:164: 'thread' is incorrectly named. It should be named 'protector' or 'protectedPreserveThisForThread'. [readability/naming/protected] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2017-01-05 14:24:56 PST
Comment on attachment 298133 [details] the patch r=me
Filip Pizlo
Comment 4 2017-01-05 16:25:27 PST
Landed in https://trac.webkit.org/changeset/210398
Note You need to log in before you can comment on or make changes to this bug.