Bug 166717

Summary:

Remove PassRefPtr use from "rendering" directory, other improvements

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebCore Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, buildbot, rniwa, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews102 for mac-elcapitan	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews116 for mac-elcapitan	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch	sam: review+, buildbot: commit-queue-
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none

Darin Adler

Reported 2017-01-04 23:33:31 PST

Remove PassRefPtr use from "rendering" directory, other improvements

Attachments
Patch (67.97 KB, patch) 2017-01-04 23:52 PST, Darin Adler	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (1.10 MB, application/zip) 2017-01-05 00:55 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1013.94 KB, application/zip) 2017-01-05 00:58 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.83 MB, application/zip) 2017-01-05 01:04 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (10.20 MB, application/zip) 2017-01-05 01:12 PST, Build Bot	no flags	Details
Patch (67.92 KB, patch) 2017-01-05 20:22 PST, Darin Adler	sam: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (801.12 KB, application/zip) 2017-01-05 21:30 PST, Build Bot	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2017-01-04 23:52:10 PST

Created attachment 298070 [details] Patch

Build Bot

Comment 2 2017-01-05 00:55:22 PST

Comment on attachment 298070 [details] Patch Attachment 298070 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2836764 New failing tests: css3/filters/css-opacity-with-drop-shadow.html imported/blink/css3/filters/effect-reference-source-alpha-not-first.html css3/filters/drop-shadow-blur-radius.html imported/blink/css3/filters/effect-reference-add-hw.html fast/filter-image/background-filter-image.html fast/filter-image/filter-image.html svg/filters/sourceAlpha-input-filter-effect.html css3/masking/clip-path-filter.html fast/css/drop-shadow-viewport-height.html fast/css/drop-shadow-viewport-vmin.html css3/filters/drop-shadow.html fast/css/drop-shadow-viewport-width.html fast/hidpi/filters-morphology.html fast/css/drop-shadow-viewport-vmax.html imported/blink/css3/filters/effect-reference-source-alpha-hw.html imported/blink/css3/filters/effect-reference-on-transparent-element.html

Build Bot

Comment 3 2017-01-05 00:55:25 PST

Created attachment 298075 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 4 2017-01-05 00:58:30 PST

Comment on attachment 298070 [details] Patch Attachment 298070 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2836768 New failing tests: css3/filters/css-opacity-with-drop-shadow.html imported/blink/css3/filters/effect-reference-source-alpha-not-first.html css3/filters/drop-shadow-blur-radius.html svg/filters/sourceAlpha-input-filter-effect.html fast/filter-image/background-filter-image.html fast/filter-image/filter-image.html imported/blink/css3/filters/effect-reference-add-hw.html css3/masking/clip-path-filter.html fast/css/drop-shadow-viewport-height.html fast/css/drop-shadow-viewport-vmin.html css3/filters/drop-shadow.html fast/css/drop-shadow-viewport-width.html fast/hidpi/filters-morphology.html fast/css/drop-shadow-viewport-vmax.html imported/blink/css3/filters/effect-reference-source-alpha-hw.html imported/blink/css3/filters/effect-reference-on-transparent-element.html

Build Bot

Comment 5 2017-01-05 00:58:33 PST

Created attachment 298076 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-01-05 01:04:27 PST

Comment on attachment 298070 [details] Patch Attachment 298070 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2836769 New failing tests: css3/filters/css-opacity-with-drop-shadow.html imported/blink/css3/filters/effect-reference-source-alpha-not-first.html css3/filters/drop-shadow-blur-radius.html svg/filters/sourceAlpha-input-filter-effect.html fast/filter-image/background-filter-image.html fast/filter-image/filter-image.html imported/blink/css3/filters/effect-reference-add-hw.html css3/masking/clip-path-filter.html fast/css/drop-shadow-viewport-height.html fast/css/drop-shadow-viewport-vmin.html css3/filters/drop-shadow.html fast/css/drop-shadow-viewport-width.html fast/hidpi/filters-morphology.html fast/css/drop-shadow-viewport-vmax.html imported/blink/css3/filters/effect-reference-source-alpha-hw.html imported/blink/css3/filters/effect-reference-on-transparent-element.html

Build Bot

Comment 7 2017-01-05 01:04:30 PST

Created attachment 298077 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 8 2017-01-05 01:12:12 PST

Comment on attachment 298070 [details] Patch Attachment 298070 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2836770 New failing tests: css3/filters/css-opacity-with-drop-shadow.html imported/blink/css3/filters/effect-reference-source-alpha-not-first.html css3/filters/drop-shadow-blur-radius.html imported/blink/css3/filters/effect-reference-add-hw.html fast/filter-image/filter-image.html svg/filters/sourceAlpha-input-filter-effect.html css3/masking/clip-path-filter.html fast/css/drop-shadow-viewport-vmin.html css3/filters/drop-shadow.html fast/css/drop-shadow-viewport-width.html fast/hidpi/filters-morphology.html fast/css/drop-shadow-viewport-vmax.html imported/blink/css3/filters/effect-reference-source-alpha-hw.html imported/blink/css3/filters/effect-reference-on-transparent-element.html

Build Bot

Comment 9 2017-01-05 01:12:15 PST

Created attachment 298078 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Darin Adler

Comment 10 2017-01-05 20:22:17 PST

Created attachment 298168 [details] Patch

Build Bot

Comment 11 2017-01-05 21:30:18 PST

Comment on attachment 298168 [details] Patch Attachment 298168 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2841692 New failing tests: css3/filters/filter-mask-clip-order.html

Build Bot

Comment 12 2017-01-05 21:30:21 PST

Created attachment 298171 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Sam Weinig

Comment 13 2017-01-06 18:50:22 PST

Comment on attachment 298168 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298168&action=review > Source/WebCore/rendering/style/NinePieceImage.h:37 > +enum ENinePieceImageRule { StretchImageRule, RoundImageRule, SpaceImageRule, RepeatImageRule }; We need to do a single pass and remove all the remaining E prefixes. Eww. > Source/WebCore/rendering/style/ShapeValue.h:40 > + static Ref<ShapeValue> create(RefPtr<BasicShape>&& shape, CSSBoxType cssBox) Can this take a Ref<BasicShape>&&, it looks like all the callers guarantee it's non-null. > Source/WebCore/rendering/style/ShapeValue.h:50 > + static Ref<ShapeValue> create(RefPtr<StyleImage>&& image) Same question.

Darin Adler

Comment 14 2017-01-06 21:24:54 PST

Committed r210469: <http://trac.webkit.org/changeset/210469>

Darin Adler

Comment 15 2017-01-06 21:32:28 PST

Comment on attachment 298168 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298168&action=review >> Source/WebCore/rendering/style/ShapeValue.h:40 >> + static Ref<ShapeValue> create(RefPtr<BasicShape>&& shape, CSSBoxType cssBox) > > Can this take a Ref<BasicShape>&&, it looks like all the callers guarantee it's non-null. Oops, forgot to do this. Will follow up. >> Source/WebCore/rendering/style/ShapeValue.h:50 >> + static Ref<ShapeValue> create(RefPtr<StyleImage>&& image) > > Same question. Ditto.

Note You need to log in before you can comment on or make changes to this bug.