Bug 166694

Summary:

[EsNext] Async iteration - Add feature flag

Product:

WebKit

Reporter:

GSkachkov <gskachkov>

Component:

JavaScriptCore

Assignee:

GSkachkov <gskachkov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, keith_miller, mark.lam, msaboff, rniwa, saam, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

166693

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews102 for mac-elcapitan	none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews115 for mac-elcapitan	none
Archive of layout-test-results from ews116 for mac-elcapitan	none
Patch	none
Patch	none

GSkachkov

Reported 2017-01-04 14:20:31 PST

Add feature flag for Async iteration

Attachments
Patch (42.96 KB, patch) 2017-08-03 01:00 PDT, GSkachkov	no flags	Details Formatted Diff Diff
Patch (42.95 KB, patch) 2017-08-03 02:22 PDT, GSkachkov	no flags	Details Formatted Diff Diff
Patch (43.21 KB, patch) 2017-08-03 04:56 PDT, GSkachkov	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (1.44 MB, application/zip) 2017-08-03 06:53 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.39 MB, application/zip) 2017-08-03 06:54 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-elcapitan (2.95 MB, application/zip) 2017-08-03 07:59 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews116 for mac-elcapitan (2.84 MB, application/zip) 2017-08-03 10:04 PDT, Build Bot	no flags	Details
Patch (1.24 KB, patch) 2017-08-04 00:33 PDT, GSkachkov	no flags	Details Formatted Diff Diff
Patch (1.92 KB, patch) 2017-08-04 00:36 PDT, GSkachkov	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

GSkachkov

Comment 1 2017-08-03 01:00:48 PDT

Created attachment 317099 [details] Patch

GSkachkov

Comment 2 2017-08-03 02:22:50 PDT

Created attachment 317107 [details] Patch Rebase

GSkachkov

Comment 3 2017-08-03 04:56:02 PDT

Created attachment 317113 [details] Patch Fix 32bit build

Yusuke Suzuki

Comment 4 2017-08-03 06:36:15 PDT

For JS features, I think adding a flag to Options is the easiest way.

Build Bot

Comment 5 2017-08-03 06:52:58 PDT

Comment on attachment 317113 [details] Patch Attachment 317113 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4246236 Number of test failures exceeded the failure limit.

Build Bot

Comment 6 2017-08-03 06:53:00 PDT

Created attachment 317119 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-08-03 06:54:45 PDT

Comment on attachment 317113 [details] Patch Attachment 317113 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4246207 Number of test failures exceeded the failure limit.

Build Bot

Comment 8 2017-08-03 06:54:47 PDT

Created attachment 317120 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 9 2017-08-03 07:59:11 PDT

Comment on attachment 317113 [details] Patch Attachment 317113 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4246394 New failing tests: inspector/debugger/tail-deleted-frames-from-vm-entry.html inspector/debugger/pause-reason.html inspector/debugger/call-frame-this-host.html inspector/debugger/breakpoint-eval-with-exception.html inspector/debugger/removeBreakpoint.html inspector/debugger/setBreakpoint-column.html inspector/debugger/hit-breakpoint-from-console.html inspector/debugger/tail-deleted-frames.html inspector/debugger/probe-manager-add-remove-actions.html inspector/debugger/setBreakpoint-autoContinue.html inspector/debugger/breakpoint-condition-with-exception.html inspector/debugger/setBreakpoint-actions.html inspector/debugger/call-frame-function-name.html inspector/debugger/setBreakpoint-condition.html inspector/debugger/breakpoint-action-detach.html inspector/debugger/setBreakpoint.html inspector/debugger/setBreakpoint-options-exception.html inspector/runtime/parse.html inspector/debugger/setBreakpointByUrl-sourceURL.html inspector/debugger/breakpoint-condition-with-bad-script.html inspector/debugger/breakpoint-inside-conditons-and-actions.html inspector/debugger/breakpoint-condition-detach.html inspector/debugger/call-frame-this-nonstrict.html inspector/debugger/call-frame-this-strict.html

Build Bot

Comment 10 2017-08-03 07:59:12 PDT

Created attachment 317121 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 11 2017-08-03 10:04:18 PDT

Comment on attachment 317113 [details] Patch Attachment 317113 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4246839 New failing tests: inspector/debugger/tail-deleted-frames-from-vm-entry.html inspector/debugger/pause-reason.html inspector/debugger/call-frame-this-host.html inspector/debugger/breakpoint-eval-with-exception.html inspector/debugger/removeBreakpoint.html inspector/debugger/setBreakpoint-column.html inspector/debugger/hit-breakpoint-from-console.html inspector/debugger/tail-deleted-frames.html inspector/debugger/probe-manager-add-remove-actions.html inspector/debugger/setBreakpoint-autoContinue.html inspector/debugger/breakpoint-condition-with-exception.html inspector/debugger/setBreakpoint-actions.html inspector/debugger/call-frame-function-name.html inspector/debugger/setBreakpoint-condition.html inspector/debugger/breakpoint-action-detach.html inspector/debugger/setBreakpoint.html inspector/debugger/setBreakpoint-options-exception.html inspector/runtime/parse.html inspector/debugger/setBreakpointByUrl-sourceURL.html inspector/debugger/breakpoint-condition-with-bad-script.html inspector/debugger/breakpoint-inside-conditons-and-actions.html inspector/debugger/breakpoint-condition-detach.html inspector/debugger/call-frame-this-nonstrict.html inspector/debugger/call-frame-this-strict.html

Build Bot

Comment 12 2017-08-03 10:04:20 PDT

Created attachment 317128 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6

GSkachkov

Comment 13 2017-08-04 00:33:38 PDT

Created attachment 317221 [details] Patch

Yusuke Suzuki

Comment 14 2017-08-04 00:36:14 PDT

Comment on attachment 317221 [details] Patch r=me

GSkachkov

Comment 15 2017-08-04 00:36:24 PDT

Created attachment 317222 [details] Patch Reimplement with using Options.h

WebKit Commit Bot

Comment 16 2017-08-04 01:51:16 PDT

Comment on attachment 317222 [details] Patch Clearing flags on attachment: 317222 Committed r220262: <http://trac.webkit.org/changeset/220262>

WebKit Commit Bot

Comment 17 2017-08-04 01:51:17 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 18 2017-08-04 01:52:40 PDT

<rdar://problem/33720032>

Saam Barati

Comment 19 2017-08-04 13:42:56 PDT

Comment on attachment 317222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317222&action=review > Source/JavaScriptCore/runtime/Options.h:517 > + v(enableAsyncIterator, useAsyncIterator, SameOption) \ Nit: This is just for legacy options. We don't need to do this for new options.

Note You need to log in before you can comment on or make changes to this bug.