Bug 166661
| Summary: | It should not be possible to set track language for in-band media | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | John Wilander <wilander> |
| Component: | Media | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | eric.carlson, jer.noble, wilander |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=123926 | ||
John Wilander
TrackBase::setLanguage() currently allows any track element to set language. The setter should first check that the track is not in-band, for instance through a convenience function in HTMLMediaElement.
This change should get rid of the ENABLE(MEDIA_SOURCE) in JSTextTrack::setLanguage() (see JSTextTrackCustom.cpp). Possibly even get rid of the custom setter all together, see [CustomSetter] attribute DOMString language in TextTrack.idl.
This change will correct the expected test results from https://bugs.webkit.org/show_bug.cgi?id=123926.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |