Bug 166641 – Reimplement RenderCounter.

• Component: Layout and Rendering
• Status: ASSIGNED

[alan]

It is mutating the render tree during layout.

[alan]

Created attachment 297903 [details]
Patch

[alan]

^^WIP patch.

[alan]

Created attachment 297991 [details]
Patch

[Build Bot]

Comment on attachment 297991 [details]
Patch

Attachment 297991 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2829898

New failing tests:
css2.1/t1204-implied-02-d.html

[Build Bot]

Created attachment 298033 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 297991 [details]
Patch

Attachment 297991 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2829909

New failing tests:
css2.1/t1204-implied-02-d.html

[Build Bot]

Created attachment 298034 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 297991 [details]
Patch

Attachment 297991 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2829907

New failing tests:
css2.1/t1204-implied-02-d.html

[Build Bot]

Created attachment 298035 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 297991 [details]
Patch

Attachment 297991 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2829914

New failing tests:
css2.1/t1204-implied-02-d.html

[Build Bot]

Created attachment 298036 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[alan]

Created attachment 298258 [details]
Patch

[alan]

Created attachment 298296 [details]
Patch

[alan]

Created attachment 298331 [details]
Patch

[alan]

Comment on attachment 298331 [details]
Patch

test

[alan]

Comment on attachment 298331 [details]
Patch

test

[alan]

Comment on attachment 298331 [details]
Patch

test

[alan]

Comment on attachment 298331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298331&action=review

> Source/WebCore/ChangeLog:8
> +

test

[alan]

Comment on attachment 298331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298331&action=review

> Source/WebCore/rendering/RenderCounter.cpp:-194
> -        if (searchEndRenderer == currentRenderer) {

test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test.

[alan]

Comment on attachment 298331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298331&action=review

> Source/WebCore/rendering/RenderElement.h:-197
> -    void setHasCounterNodeMap(bool f) { m_hasCounterNodeMap = f; }

some more test test test test test test test test test test test test test test test.

[alan]

Comment on attachment 298331 [details]
Patch

test some more

[Darin Adler]

Comment on attachment 298331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298331&action=review

> Source/WebCore/ChangeLog:7
> +        Next iteration will take care of the vast amount of counter data on RenderElement.

test

[Simon Fraser (smfr)]

Comment on attachment 298331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298331&action=review

>> Source/WebCore/ChangeLog:7
>> +        Next iteration will take care of the vast amount of counter data on RenderElement.
> 
> test

Test

>> Source/WebCore/ChangeLog:8
>> +
> 
> test

Test

>> Source/WebCore/rendering/RenderCounter.cpp:-194
>> -        if (searchEndRenderer == currentRenderer) {
> 
> test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test.

i am also testing.

[alan]

Comment on attachment 298331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298331&action=review

>>> Source/WebCore/ChangeLog:8
>>> +
>> 
>> test
> 
> Test

Test here.

>>> Source/WebCore/rendering/RenderCounter.cpp:-194
>>> -        if (searchEndRenderer == currentRenderer) {
>> 
>> test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test.
> 
> i am also testing.

Some more testing

[alan]

Comment on attachment 298331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298331&action=review

>>> Source/WebCore/ChangeLog:7
>>> +        Next iteration will take care of the vast amount of counter data on RenderElement.
>> 
>> test
> 
> Test

Test

>>>> Source/WebCore/ChangeLog:8
>>>> +
>>> 
>>> test
>> 
>> Test
> 
> Test here.

Test

>>>> Source/WebCore/rendering/RenderCounter.cpp:-194
>>>> -        if (searchEndRenderer == currentRenderer) {
>>> 
>>> test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test test.
>> 
>> i am also testing.
> 
> Some more testing

Testing here too.