Bug 166579
| Summary: | check-webkit-style should not warn about #ifndef header guards in API headers | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | bugs-noreply, lforschler, mcatanzaro |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Michael Catanzaro
check-webkit-style should not warn about #ifndef header guards in API headers:
ERROR: Source/WebKit2/UIProcess/API/gtk/WebKitSecurityOriginPrivate.h:20: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5]
This file is an installed API header, so we shouldn't use #pragma once.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
Well the problem is I can't read, that's the non-installed Private header. It's properly ignoring all the installed headers. The script is correct.