Bug 166539 – GraphicsContextCairo: setMiterLimit() is missing the DisplayListRecorder diversion

• Component: New Bugs
• Status: RESOLVED FIXED

[Zan Dobersek]

GraphicsContextCairo: setMiterLimit() is missing the DisplayListRecorder diversion

[Zan Dobersek]

Created attachment 297815 [details]
Patch

[Michael Catanzaro]

Comment on attachment 297815 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297815&action=review

The amount of code duplication between these classes is quite worrisome. Things are just going to get desynced again in the future. :/

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1021
> +        m_displayListRecorder->setMiterLimit(limit);

EWS is red: limit was not declared in this scope. The parameter is named differently here than in GraphicsContextCG.

[Zan Dobersek]

(In reply to comment #2)
> Comment on attachment 297815 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=297815&action=review
> 
> The amount of code duplication between these classes is quite worrisome.
> Things are just going to get desynced again in the future. :/
> 

True, maybe a recording-specific GraphicsContext class could work.

> > Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:1021
> > +        m_displayListRecorder->setMiterLimit(limit);
> 
> EWS is red: limit was not declared in this scope. The parameter is named
> differently here than in GraphicsContextCG.

Oops!

[Zan Dobersek]

Created attachment 297873 [details]
Patch for landing

[Zan Dobersek]

Comment on attachment 297873 [details]
Patch for landing

Clearing flags on attachment: 297873

Committed r210220: <http://trac.webkit.org/changeset/210220>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.