Bug 166524

Summary:

REGRESSION(r99965): Web Inspector: large inline scripts and text nodes are truncated at 10,000 characters

Product:

WebKit

Reporter:

Blaze Burg <bburg>

Component:

Web Inspector

Assignee:

Blaze Burg <bburg>

Status:

NEW

Severity:

Normal

CC:

bburg, buildbot, inspector-bugzilla-changes, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Cumulative Diff (for EWS)	joepeck: review-, buildbot: commit-queue-
[PATCH 1/3] WrappedPromise changes	none
[PATCH 2/3] Add promises to DOMTreeManager	buildbot: commit-queue-
[PATCH 3/3] Fix the bug and add a regression test	none
Archive of layout-test-results from ews102 for mac-elcapitan	none
Archive of layout-test-results from ews115 for mac-elcapitan	none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews101 for mac-elcapitan	none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews114 for mac-elcapitan	none

Blaze Burg

Reported 2016-12-27 16:27:30 PST

<rdar://problem/13465082>

Attachments
[PATCH] Cumulative Diff (for EWS) (12.19 KB, patch) 2016-12-27 16:38 PST, Blaze Burg	joepeck: review- buildbot: commit-queue-	Details Formatted Diff Diff
[PATCH 1/3] WrappedPromise changes (7.47 KB, patch) 2016-12-27 16:38 PST, Blaze Burg	no flags	Details Formatted Diff Diff
[PATCH 2/3] Add promises to DOMTreeManager (12.19 KB, patch) 2016-12-27 16:38 PST, Blaze Burg	buildbot: commit-queue-	Details Formatted Diff Diff
[PATCH 3/3] Fix the bug and add a regression test (26.39 KB, patch) 2016-12-27 16:38 PST, Blaze Burg	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (1.00 MB, application/zip) 2016-12-27 17:59 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-elcapitan (1.75 MB, application/zip) 2016-12-27 18:12 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (2.33 MB, application/zip) 2016-12-27 19:28 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews101 for mac-elcapitan (874.34 KB, application/zip) 2016-12-29 13:08 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (2.60 MB, application/zip) 2016-12-29 14:59 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-elcapitan (1.75 MB, application/zip) 2016-12-29 15:37 PST, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Blaze Burg

Comment 1 2016-12-27 16:38:00 PST

Created attachment 297792 [details] [PATCH] Cumulative Diff (for EWS)

Blaze Burg

Comment 2 2016-12-27 16:38:07 PST

Created attachment 297793 [details] [PATCH 1/3] WrappedPromise changes

Blaze Burg

Comment 3 2016-12-27 16:38:16 PST

Created attachment 297794 [details] [PATCH 2/3] Add promises to DOMTreeManager

Blaze Burg

Comment 4 2016-12-27 16:38:24 PST

Created attachment 297795 [details] [PATCH 3/3] Fix the bug and add a regression test

Blaze Burg

Comment 5 2016-12-27 16:38:57 PST

Comment on attachment 297793 [details] [PATCH 1/3] WrappedPromise changes This patch is tracked by a separate bug, but I added it here for reference and so EWS would work.

Build Bot

Comment 6 2016-12-27 17:59:23 PST

Comment on attachment 297792 [details] [PATCH] Cumulative Diff (for EWS) Attachment 297792 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2796007 New failing tests: inspector/css/generate-css-rule-string.html inspector/css/stylesheet-with-mutations.html inspector/dom/domutilities-path-dump.html inspector/dom/shadowRootType.html inspector/dom/setOuterHTML.html inspector/dom/customElementState.html inspector/dom/highlight-shape-outside-margin.html inspector/dom/domutilities-xpath.html inspector/dom/pseudo-element-dynamic.html inspector/dom/domutilities-csspath.html inspector/dom/hideHighlight.html inspector/dom/getOuterHTML.html inspector/dom/pseudo-element-static.html inspector/dom/csp-hash.html inspector/console/addInspectedNode.html inspector/dom/csp-big5-hash.html inspector/dom/highlightNode.html inspector/console/command-line-api.html inspector/css/shadow-scoped-style.html inspector/dom/template-content.html http/tests/inspector/console/cross-domain-inspected-node-access.html

Build Bot

Comment 7 2016-12-27 17:59:26 PST

Created attachment 297797 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 8 2016-12-27 18:12:32 PST

Comment on attachment 297792 [details] [PATCH] Cumulative Diff (for EWS) Attachment 297792 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2796024 New failing tests: inspector/css/generate-css-rule-string.html inspector/css/stylesheet-with-mutations.html inspector/dom/domutilities-path-dump.html inspector/dom/shadowRootType.html inspector/dom/customElementState.html inspector/dom/highlight-shape-outside-margin.html inspector/dom/domutilities-xpath.html inspector/dom/setOuterHTML.html inspector/dom/domutilities-csspath.html inspector/dom/hideHighlight.html inspector/dom/getOuterHTML.html inspector/dom/pseudo-element-static.html inspector/dom/csp-hash.html inspector/dom/pseudo-element-dynamic.html inspector/dom/csp-big5-hash.html inspector/dom/highlightNode.html inspector/console/command-line-api.html inspector/css/shadow-scoped-style.html inspector/dom/template-content.html http/tests/inspector/console/cross-domain-inspected-node-access.html

Build Bot

Comment 9 2016-12-27 18:12:35 PST

Created attachment 297798 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 10 2016-12-27 19:28:40 PST

Comment on attachment 297792 [details] [PATCH] Cumulative Diff (for EWS) Attachment 297792 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2796145 New failing tests: inspector/css/generate-css-rule-string.html inspector/css/stylesheet-with-mutations.html inspector/dom/domutilities-path-dump.html inspector/dom/shadowRootType.html inspector/dom/setOuterHTML.html inspector/dom/customElementState.html inspector/dom/highlight-shape-outside-margin.html inspector/dom/domutilities-xpath.html inspector/dom/pseudo-element-dynamic.html inspector/dom/domutilities-csspath.html inspector/dom/hideHighlight.html inspector/dom/getOuterHTML.html inspector/dom/pseudo-element-static.html inspector/dom/csp-hash.html inspector/console/addInspectedNode.html inspector/dom/csp-big5-hash.html inspector/dom/highlightNode.html inspector/console/command-line-api.html inspector/css/shadow-scoped-style.html inspector/dom/template-content.html http/tests/inspector/console/cross-domain-inspected-node-access.html

Build Bot

Comment 11 2016-12-27 19:28:44 PST

Created attachment 297799 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 12 2016-12-29 13:08:32 PST

Comment on attachment 297794 [details] [PATCH 2/3] Add promises to DOMTreeManager Attachment 297794 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2803784 New failing tests: inspector/css/generate-css-rule-string.html inspector/css/stylesheet-with-mutations.html inspector/dom/domutilities-path-dump.html inspector/dom/shadowRootType.html http/tests/inspector/console/cross-domain-inspected-node-access.html inspector/dom/setOuterHTML.html inspector/dom/customElementState.html inspector/dom/highlight-shape-outside-margin.html inspector/dom/domutilities-xpath.html inspector/dom/pseudo-element-dynamic.html inspector/dom/domutilities-csspath.html inspector/dom/hideHighlight.html inspector/dom/getOuterHTML.html inspector/dom/pseudo-element-static.html inspector/dom/csp-hash.html inspector/console/addInspectedNode.html inspector/dom/csp-big5-hash.html inspector/dom/highlightNode.html inspector/css/shadow-scoped-style.html inspector/dom/template-content.html inspector/console/command-line-api.html

Build Bot

Comment 13 2016-12-29 13:08:35 PST

Created attachment 297839 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 14 2016-12-29 14:59:49 PST

Comment on attachment 297794 [details] [PATCH 2/3] Add promises to DOMTreeManager Attachment 297794 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2803911 New failing tests: inspector/css/generate-css-rule-string.html inspector/css/stylesheet-with-mutations.html inspector/dom/domutilities-path-dump.html inspector/dom/shadowRootType.html http/tests/inspector/console/cross-domain-inspected-node-access.html inspector/console/addInspectedNode.html inspector/dom/customElementState.html inspector/dom/highlight-shape-outside-margin.html inspector/dom/domutilities-xpath.html inspector/dom/setOuterHTML.html inspector/dom/domutilities-csspath.html inspector/dom/template-content.html inspector/dom/hideHighlight.html inspector/dom/getOuterHTML.html inspector/dom/csp-hash.html inspector/dom/pseudo-element-dynamic.html inspector/dom/csp-big5-hash.html inspector/dom/highlightNode.html inspector/css/shadow-scoped-style.html inspector/dom/pseudo-element-static.html inspector/console/command-line-api.html

Build Bot

Comment 15 2016-12-29 14:59:52 PST

Created attachment 297843 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 16 2016-12-29 15:37:31 PST

Comment on attachment 297794 [details] [PATCH 2/3] Add promises to DOMTreeManager Attachment 297794 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2804132 New failing tests: inspector/css/generate-css-rule-string.html inspector/css/stylesheet-with-mutations.html inspector/dom/domutilities-path-dump.html inspector/dom/shadowRootType.html inspector/dom/customElementState.html inspector/dom/highlight-shape-outside-margin.html inspector/dom/domutilities-xpath.html inspector/dom/setOuterHTML.html inspector/dom/domutilities-csspath.html inspector/dom/hideHighlight.html inspector/dom/getOuterHTML.html inspector/dom/pseudo-element-static.html inspector/dom/csp-hash.html inspector/dom/pseudo-element-dynamic.html inspector/dom/csp-big5-hash.html inspector/dom/highlightNode.html inspector/console/command-line-api.html inspector/css/shadow-scoped-style.html inspector/dom/template-content.html http/tests/inspector/console/cross-domain-inspected-node-access.html

Build Bot

Comment 17 2016-12-29 15:37:35 PST

Created attachment 297844 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Joseph Pecoraro

Comment 18 2017-01-03 14:04:09 PST

Comment on attachment 297793 [details] [PATCH 1/3] WrappedPromise changes This moved into its own bug apparently (Bug 166523)

Joseph Pecoraro

Comment 19 2017-01-03 14:07:08 PST

Comment on attachment 297795 [details] [PATCH 3/3] Fix the bug and add a regression test This change looks fine to me, but lots of tests are failing. Those should be investigated.

Joseph Pecoraro

Comment 20 2017-01-03 14:11:54 PST

Comment on attachment 297794 [details] [PATCH 2/3] Add promises to DOMTreeManager View in context: https://bugs.webkit.org/attachment.cgi?id=297794&action=review > Source/WebInspectorUI/UserInterface/Controllers/DOMTreeManager.js:-108 > - callback(error ? null : result); It looks like this old code would run the callback with null if there was an error. New code passes the error string.

Joseph Pecoraro

Comment 21 2017-01-03 14:12:55 PST

Comment on attachment 297792 [details] [PATCH] Cumulative Diff (for EWS) r- due to the tests failing, but see comments on the other parts which points out a change that may have caused this.

Blaze Burg

Comment 22 2017-01-03 17:10:33 PST

(In reply to comment #21) > Comment on attachment 297792 [details] > [PATCH] Cumulative Diff (for EWS) > > r- due to the tests failing, but see comments on the other parts which > points out a change that may have caused this. This patch series was uploaded prior to fixing all of the tests. Since that task got so big, I moved it into this separate bug: https://bugs.webkit.org/show_bug.cgi?id=166634 That in turn is blocked on the WrappedPromise and reportUnhandledRejection bugs, which are in commit-queue now. I'll rebase and re-upload what's remaining to this bug and 166634 tonight or tomorrow so they have accurate EWS results.

Note You need to log in before you can comment on or make changes to this bug.