Bug 166490

Summary: WebAssembly: Don't allow duplicate export names
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, oliver, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2016-12-27 10:19:47 PST
...
Attachments
patch (3.88 KB, patch)
2016-12-28 16:31 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-12-27 10:30:34 PST
<rdar://problem/29815000>
Saam Barati
Comment 2 2016-12-27 10:34:10 PST
Looks like this requires my grow_memory patch to fix the test which fixes creating memory w/ initial size of zero.
Saam Barati
Comment 3 2016-12-28 16:31:03 PST
Created attachment 297816 [details] patch
Keith Miller
Comment 4 2016-12-28 18:39:25 PST
Comment on attachment 297816 [details] patch r=me.
WebKit Commit Bot
Comment 5 2016-12-28 19:10:54 PST
Comment on attachment 297816 [details] patch Clearing flags on attachment: 297816 Committed r210203: <http://trac.webkit.org/changeset/210203>
WebKit Commit Bot
Comment 6 2016-12-28 19:11:00 PST
All reviewed patches have been landed. Closing bug.
JF Bastien
Comment 7 2016-12-29 08:51:17 PST
Hmm, I find this surprising since duplicates aren't useful but are also harmless. I filed a PR in the design repo to add this restriction: https://github.com/WebAssembly/design/pull/932 It seems silly to restrict when overwrite semantics is clear and requires less work. In any case, this is a good PR to follow the spec, a nice corner case, and reversing polarity is easy in the future.
Note You need to log in before you can comment on or make changes to this bug.