Bug 166469

Summary: REGRESSION(r209865): Crash when navigating back to some pages with compositing layers.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, kling, simon.fraser
Priority: P2 Keywords: InRadar, Regression
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andreas Kling 2016-12-23 15:02:05 PST
When activating the FrameView::clearBackingStores() optimization on all platforms, some crashiness was introduced.
It doesn't look like the optimization actually helps memory usage any any significant way anymore, so I think we should just get rid of it.

<rdar://problem/29109053>
Comment 1 Andreas Kling 2016-12-23 15:14:40 PST
Created attachment 297721 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-12-23 15:20:35 PST
Comment on attachment 297721 [details]
Patch

Why did you enable it on Mac if it wasn't a measurable gain?
Comment 3 Andreas Kling 2016-12-23 15:29:26 PST
(In reply to comment #2)
> Comment on attachment 297721 [details]
> Patch
> 
> Why did you enable it on Mac if it wasn't a measurable gain?

For consistency, as I wrote in the original ChangeLog. I saw a chance to remove an iOS-only code path and potentially also get a win for Mac, and jumped at it. It was all seasonal wishful thinking :\
Comment 4 WebKit Commit Bot 2016-12-23 16:24:21 PST
Comment on attachment 297721 [details]
Patch

Clearing flags on attachment: 297721

Committed r210142: <http://trac.webkit.org/changeset/210142>
Comment 5 WebKit Commit Bot 2016-12-23 16:24:25 PST
All reviewed patches have been landed.  Closing bug.