Bug 166452

Summary: reduce PassRefPtr use in WebKit2
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue, gustavo, mcatanzaro, mrobinson
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2016-12-22 17:21:53 PST
reduce PassRefPtr use in WebKit2
Attachments
Patch (23.60 KB, patch)
2016-12-23 08:53 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (24.72 KB, patch)
2016-12-24 00:07 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (25.56 KB, patch)
2016-12-26 21:49 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-12-23 08:53:23 PST
Created attachment 297709 [details] Patch
WebKit Commit Bot
Comment 2 2016-12-23 08:55:20 PST
Attachment 297709 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:64: 'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'. [readability/naming/protected] [4] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 3 2016-12-24 00:07:15 PST
Created attachment 297739 [details] Patch
WebKit Commit Bot
Comment 4 2016-12-24 00:10:01 PST
Attachment 297739 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:64: 'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'. [readability/naming/protected] [4] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 5 2016-12-26 21:49:27 PST
Created attachment 297778 [details] Patch
WebKit Commit Bot
Comment 6 2016-12-26 21:51:37 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 7 2016-12-26 21:51:51 PST
Attachment 297778 [details] did not pass style-queue: ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:64: 'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'. [readability/naming/protected] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 8 2016-12-26 23:11:36 PST
Comment on attachment 297778 [details] Patch r=me
WebKit Commit Bot
Comment 9 2016-12-27 18:49:08 PST
Comment on attachment 297778 [details] Patch Clearing flags on attachment: 297778 Committed r210181: <http://trac.webkit.org/changeset/210181>
WebKit Commit Bot
Comment 10 2016-12-27 18:49:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.