Bug 166449

Summary: [iOS] Move QuickLook from WebCore/platform to WebCore/loader
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cdumez, commit-queue, dbates, dino, japhet, sam, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andy Estes
Reported 2016-12-22 17:11:47 PST
[iOS] Move QuickLook from WebCore/platform to WebCore/loader
Attachments
Patch (57.71 KB, patch)
2016-12-22 17:17 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2016-12-22 17:17:37 PST
Created attachment 297692 [details] Patch
WebKit Commit Bot
Comment 2 2016-12-22 17:18:54 PST
Attachment 297692 [details] did not pass style-queue: ERROR: Source/WebCore/loader/ios/QuickLook.mm:64: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/loader/ios/QuickLook.mm:75: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/loader/ios/QuickLook.mm:382: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WebCore/loader/ios/QuickLook.mm:383: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/loader/ios/QuickLook.mm:384: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/loader/ios/QuickLook.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] Total errors found: 6 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 3 2016-12-22 17:20:22 PST
Comment on attachment 297692 [details] Patch rs=me
WebKit Commit Bot
Comment 4 2016-12-22 18:25:12 PST
Comment on attachment 297692 [details] Patch Clearing flags on attachment: 297692 Committed r210129: <http://trac.webkit.org/changeset/210129>
WebKit Commit Bot
Comment 5 2016-12-22 18:25:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.