| Summary: | [iOS] Move QuickLook from WebCore/platform to WebCore/loader | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||
| Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, cdumez, commit-queue, dbates, dino, japhet, sam, simon.fraser, thorton | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Andy Estes
2016-12-22 17:11:47 PST
Created attachment 297692 [details]
Patch
Attachment 297692 [details] did not pass style-queue:
ERROR: Source/WebCore/loader/ios/QuickLook.mm:64: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
ERROR: Source/WebCore/loader/ios/QuickLook.mm:75: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
ERROR: Source/WebCore/loader/ios/QuickLook.mm:382: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
ERROR: Source/WebCore/loader/ios/QuickLook.mm:383: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/loader/ios/QuickLook.mm:384: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
ERROR: Source/WebCore/loader/ios/QuickLook.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5]
Total errors found: 6 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 297692 [details]
Patch
rs=me
Comment on attachment 297692 [details] Patch Clearing flags on attachment: 297692 Committed r210129: <http://trac.webkit.org/changeset/210129> All reviewed patches have been landed. Closing bug. |