Bug 166401

Summary:

[Cocoa] SPI for setloadsImagesAutomatically

Product:

WebKit

Reporter:

Zach Li <a.tion.surf>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

a.tion.surf, beidson, commit-queue, jberlin

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Zach Li 2016-12-21 17:23:08 PST

Cocoa SPI for setloadsImagesAutomatically.

Comment 1 Zach Li 2016-12-21 17:40:19 PST

Created attachment 297642 [details]
Patch

Comment 2 Alex Christensen 2016-12-22 11:27:33 PST

Comment on attachment 297642 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297642&action=review

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:51
> +    [preferences _setLoadsImagesAutomatically:NO];
> +    EXPECT_FALSE([preferences _loadsImagesAutomatically]);

This doesn't test the actual functionality of the preference.

Comment 3 WebKit Commit Bot 2016-12-22 11:50:20 PST

Comment on attachment 297642 [details]
Patch

Clearing flags on attachment: 297642

Committed r210103: <http://trac.webkit.org/changeset/210103>

Comment 4 WebKit Commit Bot 2016-12-22 11:50:24 PST

All reviewed patches have been landed.  Closing bug.