Bug 166401

Summary: [Cocoa] SPI for setloadsImagesAutomatically
Product: WebKit Reporter: Zach Li <a.tion.surf>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: a.tion.surf, beidson, commit-queue, jberlin
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Zach Li
Reported 2016-12-21 17:23:08 PST
Cocoa SPI for setloadsImagesAutomatically.
Attachments
Patch (4.83 KB, patch)
2016-12-21 17:40 PST, Zach Li 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zach Li
Comment 1 2016-12-21 17:40:19 PST
Created attachment 297642 [details] Patch
Alex Christensen
Comment 2 2016-12-22 11:27:33 PST
Comment on attachment 297642 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297642&action=review > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:51 > + [preferences _setLoadsImagesAutomatically:NO]; > + EXPECT_FALSE([preferences _loadsImagesAutomatically]); This doesn't test the actual functionality of the preference.
WebKit Commit Bot
Comment 3 2016-12-22 11:50:20 PST
Comment on attachment 297642 [details] Patch Clearing flags on attachment: 297642 Committed r210103: <http://trac.webkit.org/changeset/210103>
WebKit Commit Bot
Comment 4 2016-12-22 11:50:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.