Bug 166356

Summary: WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, EmmaGSherman, lforschler, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch - add comment none

Description Daniel Bates 2016-12-21 11:28:41 PST 
The remark in the patch for bug #43389 makes it unclear whether we should remove the test plugins/get-url-with-blank-target.html. Should we feel this test has value and want to keep it then we will need to implement testRunner.setCanOpenWindows() in WebKitTestRunner such that WebKitTestRunner forbids opening windows by default (this matches the behavior in DumpRenderTree). We should update the comment in TestRunner::setCanOpenWindows() to explain its purpose should we decide to keep the test plugins/get-url-with-blank-target.html.
Comment 1 Daniel Bates 2016-12-21 11:33:45 PST 
Created attachment 297610 [details]
Patch - add comment
Comment 2 Daniel Bates 2016-12-21 11:36:42 PST 
Committed r210070: <http://trac.webkit.org/changeset/210070>