Bug 166331

Summary: webkit-test-runner options aren't recognised with HTTP tests
Product: WebKit Reporter: Antoine Quint <graouts>
Component: Tools / TestsAssignee: Antoine Quint <graouts>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ap, lforschler, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 165668    
Attachments:
Description Flags
Patch none

Antoine Quint
Reported 2016-12-21 08:45:57 PST
Using a comment like <!-- webkit-test-runner [ enableModernMediaControls=false ] --> at the top of a test should disable modern media controls for a given test. This works well with tests there file: URLs, but not with http: URLs, such as any of the tests under http/. I've traced the problem to `static std::string testPath(WKURLRef url)` which only knows how to deal with file: URLs and returns an empty string otherwise, which means that test options aren't parsed due to returning early in updateTestOptionsFromTestHeader() if filename.empty().
Attachments
Patch (147.72 KB, text/plain)
2016-12-21 10:30 PST, Antoine Quint 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-12-21 08:46:31 PST
<rdar://problem/29772341>
Antoine Quint
Comment 2 2016-12-21 10:30:39 PST
Created attachment 297598 [details] Patch
Antoine Quint
Comment 3 2016-12-21 10:31:42 PST
Comment on attachment 297598 [details] Patch Uploaded patch for the wrong bug.
Antoine Quint
Comment 4 2017-01-05 11:31:51 PST
*** This bug has been marked as a duplicate of bug 149812 ***
Note You need to log in before you can comment on or make changes to this bug.