Bug 166297 – REGRESSION (r209396): Web Inspector: Uncommenting CSS properties doesn't work for inline styles

• Component: Web Inspector
• Status: RESOLVED DUPLICATE

[Nikita Vasilyev]

Created attachment 297569 [details]
[HTML] Reduction

Steps:
1. Open attached reduction.
2. Inspect "Paragraph".
3. In the Styles sidebar, click on the checkbox to comment out "color: red" rule.
4. Click on this checkbox again.

Expected:
Uncommented rule, e.g. "color: red".

Actual:
Doubly commented rule, e.g. "/* /* color: red */ */".

[Nikita Vasilyev]

Created attachment 297570 [details]
Patch

[Nikita Vasilyev]

Created attachment 297572 [details]
[Animated GIF] With patch applied

Before the patch: https://bug-165831-attachments.webkit.org/attachment.cgi?id=297480

[Radar WebKit Bug Importer]

<rdar://problem/29767412>

[Blaze Burg]

Comment on attachment 297570 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 297570 [details]
Patch

Clearing flags on attachment: 297570

Committed r210069: <http://trac.webkit.org/changeset/210069>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Nikita Vasilyev]

The new CSS parser somehow broke this.
https://trac.webkit.org/changeset/209396/trunk

[WebKit Commit Bot]

Re-opened since this is blocked by bug 166439

[Nikita Vasilyev]

Before the new CSS parser, disabling a CSS property by clicking a checkbox would result in WebInspector.CSSStyleDeclaration.Event.PropertiesChanged event being fired:

    {
        addedProperties: [],
        removedProperties: [
            {
                _text: "color: red",
                _enabled: true,
                ...
            }
        ]
    }

It stopped happening with the new parser (r209396+).

[Joseph Pecoraro]

Duping to the single bug to handle CSS Toggling issues:

*** This bug has been marked as a duplicate of bug 166786 ***