Bug 16629

Summary:

<canvas> does not support isPointInPath()

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

DOM

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

darin

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.4

URL:

http://www.whatwg.org/specs/web-apps/current-work/#ispointinpath

Attachments:

Description	Flags
Add support for isPointInPath	sam: review-
Appease sam, yet more testcases!	sam: review+

Description Eric Seidel (no email) 2007-12-27 23:15:32 PST

<canvas> does not support isPointInPath()

This is a Mozilla extension to <canvas> which HTML5 seems to have picked up:
http://www.whatwg.org/specs/web-apps/current-work/#ispointinpath

Comment 1 Oliver Hunt 2008-01-27 20:54:26 PST

Created attachment 18732 [details]
Add support for isPointInPath

Comment 2 Sam Weinig 2008-01-27 22:14:09 PST

Comment on attachment 18732 [details]
Add support for isPointInPath

I am going to tentatively r- this because I believe you need to account for the case when the transform is non-invertable and there should be an accompanying test case.

Comment 3 Oliver Hunt 2008-01-27 22:54:49 PST

Created attachment 18733 [details]
Appease sam, yet more testcases!

Comment 4 Oliver Hunt 2008-01-27 22:56:09 PST

I have corrected the tyop in the test case s/invertible/non-invertible

Comment 5 Sam Weinig 2008-01-27 22:58:44 PST

Comment on attachment 18733 [details]
Appease sam, yet more testcases!

Looks good.  You are missing a new line and the test case could use a description() like many of the others.

Comment 6 Oliver Hunt 2008-01-27 23:06:40 PST

Landed in r29827