Bug 16629

Summary:

<canvas> does not support isPointInPath()

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

DOM

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

darin

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.4

URL:

http://www.whatwg.org/specs/web-apps/current-work/#ispointinpath

Attachments:

Description	Flags
Add support for isPointInPath	sam: review-
Appease sam, yet more testcases!	sam: review+

Eric Seidel (no email)

Reported 2007-12-27 23:15:32 PST

<canvas> does not support isPointInPath() This is a Mozilla extension to <canvas> which HTML5 seems to have picked up: http://www.whatwg.org/specs/web-apps/current-work/#ispointinpath

Attachments
Add support for isPointInPath (10.68 KB, patch) 2008-01-27 20:54 PST, Oliver Hunt	sam: review-	Details Formatted Diff Diff
Appease sam, yet more testcases! (12.18 KB, patch) 2008-01-27 22:54 PST, Oliver Hunt	sam: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Oliver Hunt

Comment 1 2008-01-27 20:54:26 PST

Created attachment 18732 [details] Add support for isPointInPath

Sam Weinig

Comment 2 2008-01-27 22:14:09 PST

Comment on attachment 18732 [details] Add support for isPointInPath I am going to tentatively r- this because I believe you need to account for the case when the transform is non-invertable and there should be an accompanying test case.

Oliver Hunt

Comment 3 2008-01-27 22:54:49 PST

Created attachment 18733 [details] Appease sam, yet more testcases!

Oliver Hunt

Comment 4 2008-01-27 22:56:09 PST

I have corrected the tyop in the test case s/invertible/non-invertible

Sam Weinig

Comment 5 2008-01-27 22:58:44 PST

Comment on attachment 18733 [details] Appease sam, yet more testcases! Looks good. You are missing a new line and the test case could use a description() like many of the others.

Oliver Hunt

Comment 6 2008-01-27 23:06:40 PST

Landed in r29827

Note You need to log in before you can comment on or make changes to this bug.