Bug 166038

Summary:

LayoutTest http/tests/inspector/network/fetch-network-data.html is a flaky timeout

Product:

WebKit

Reporter:

Ryan Haddad <ryanhaddad>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	none
[PATCH] Proposed Fix	none

Description Ryan Haddad 2016-12-19 14:27:35 PST

LayoutTest http/tests/inspector/network/fetch-network-data.html is a flaky timeout

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r209990%20(1428)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Finspector%2Fnetwork%2Ffetch-network-data.html

Comment 1 Ryan Haddad 2016-12-19 14:28:47 PST

This test was added with https://trac.webkit.org/changeset/209734, and appears to have been flaky from the start.

Comment 2 Ryan Haddad 2016-12-19 15:37:45 PST

Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/209999

Comment 3 Joseph Pecoraro 2017-05-03 14:34:32 PDT

Created attachment 308955 [details]
[PATCH] Proposed Fix

With this change I'm able to `run-webkit-tests http/tests/inspector/network --iterations=40 --force` without errors. Previously this test was failing approximately the second iteration onwards (when the response comes from the disk cache).

Comment 4 Joseph Pecoraro 2017-05-03 14:50:03 PDT

Comment on attachment 308955 [details]
[PATCH] Proposed Fix

Clearing review flag. There is another test that would benefit from the same change.

Comment 5 Matt Baker 2017-05-03 14:52:06 PDT

With --iterations=100 I get:

[791/1800] http/tests/inspector/network/xhr-request-data-encoded-correctly.html failed unexpectedly (test timed out, text diff)
[1025/1800] http/tests/inspector/network/xhr-request-data-encoded-correctly.html failed unexpectedly (test timed out, text diff)

Comment 6 Joseph Pecoraro 2017-05-03 14:54:42 PDT

Created attachment 308959 [details]
[PATCH] Proposed Fix

Comment 7 Joseph Pecoraro 2017-05-03 14:55:15 PDT

<rdar://problem/29488489>

Comment 8 Joseph Pecoraro 2017-05-03 14:55:41 PDT

*** Bug 164033 has been marked as a duplicate of this bug. ***

Comment 9 Matt Baker 2017-05-03 15:00:18 PDT

Comment on attachment 308959 [details]
[PATCH] Proposed Fix

r=me

Passed with --iterations=100

Comment 10 WebKit Commit Bot 2017-05-03 15:30:41 PDT

Comment on attachment 308959 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 308959

Committed r216150: <http://trac.webkit.org/changeset/216150>

Comment 11 WebKit Commit Bot 2017-05-03 15:30:43 PDT

All reviewed patches have been landed.  Closing bug.