Bug 165992

Summary: [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, beidson, commit-queue, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=165517
Attachments:
Description Flags
Patch
none
Patch none

Description Andy Estes 2016-12-16 23:46:54 PST 
[Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
Comment 1 Andy Estes 2016-12-16 23:47:44 PST 
rdar://problem/29693817
Comment 2 Andy Estes 2016-12-17 00:13:53 PST 
Created attachment 297397 [details]
Patch
Comment 3 Andy Estes 2016-12-17 00:18:55 PST 
Created attachment 297398 [details]
Patch
Comment 4 WebKit Commit Bot 2016-12-17 00:21:44 PST 
Attachment 297398 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/Cocoa/CompletionHandlerCallChecker.mm:34:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Commit Bot 2016-12-20 13:19:11 PST 
Comment on attachment 297398 [details]
Patch

Clearing flags on attachment: 297398

Committed r210031: <http://trac.webkit.org/changeset/210031>
Comment 6 WebKit Commit Bot 2016-12-20 13:19:15 PST 
All reviewed patches have been landed.  Closing bug.