Bug 165992 - [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
Summary: [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webVi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-16 23:46 PST by Andy Estes
Modified: 2016-12-20 13:19 PST (History)
6 users (show)

See Also:


Attachments
Patch (28.93 KB, patch)
2016-12-17 00:13 PST, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (28.91 KB, patch)
2016-12-17 00:18 PST, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2016-12-16 23:46:54 PST
[Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
Comment 1 Andy Estes 2016-12-16 23:47:44 PST
rdar://problem/29693817
Comment 2 Andy Estes 2016-12-17 00:13:53 PST
Created attachment 297397 [details]
Patch
Comment 3 Andy Estes 2016-12-17 00:18:55 PST
Created attachment 297398 [details]
Patch
Comment 4 WebKit Commit Bot 2016-12-17 00:21:44 PST
Attachment 297398 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/Cocoa/CompletionHandlerCallChecker.mm:34:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Commit Bot 2016-12-20 13:19:11 PST
Comment on attachment 297398 [details]
Patch

Clearing flags on attachment: 297398

Committed r210031: <http://trac.webkit.org/changeset/210031>
Comment 6 WebKit Commit Bot 2016-12-20 13:19:15 PST
All reviewed patches have been landed.  Closing bug.