Bug 165983

Summary: Visual viewports: bottom fixed elements disappear behind the keyboard
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, enrica, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
simon.fraser: review+
Patch for landing
none
Fix iOS testing. none

Wenson Hsieh
Reported 2016-12-16 18:54:50 PST
0. Enable visual viewports when focusing assisted nodes 1. Go to whsieh.github.io/examples/fixed-inputs 2. Focus the bottom <input> Observed: bottom <input> is obscured behind the keyboard.
Attachments
Patch (63.92 KB, patch)
2016-12-16 20:35 PST, Wenson Hsieh 		simon.fraser: review+
DetailsFormatted DiffDiff
Patch for landing (64.35 KB, patch)
2016-12-17 10:41 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix iOS testing. (8.91 KB, patch)
2016-12-17 23:45 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2016-12-16 20:35:16 PST
Created attachment 297390 [details] Patch
Wenson Hsieh
Comment 2 2016-12-16 20:36:19 PST
<rdar://problem/29409852>
WebKit Commit Bot
Comment 3 2016-12-16 20:37:01 PST
Attachment 297390 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/VisibleContentRectUpdateInfo.h:54: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 1 in 47 files If any of these errors are false positives, please file a bug against check-webkit-style.
Wenson Hsieh
Comment 4 2016-12-17 10:41:20 PST
Thanks Simon! Looks like there's one more test I need to rebaseline (fast/viewport/ios/width-is-device-width-expected.txt). I'll do that before landing.
Wenson Hsieh
Comment 5 2016-12-17 10:41:55 PST
Created attachment 297410 [details] Patch for landing
WebKit Commit Bot
Comment 6 2016-12-17 11:18:51 PST
Comment on attachment 297410 [details] Patch for landing Clearing flags on attachment: 297410 Committed r209967: <http://trac.webkit.org/changeset/209967>
Simon Fraser (smfr)
Comment 7 2016-12-17 23:20:30 PST
This caused hundreds of compositing failures for iso-simulator: https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20(Tests)/r209967%20(2310)/results.html
Simon Fraser (smfr)
Comment 8 2016-12-17 23:45:44 PST
Reopening to attach new patch.
Simon Fraser (smfr)
Comment 9 2016-12-17 23:45:46 PST
Created attachment 297426 [details] Fix iOS testing.
WebKit Commit Bot
Comment 10 2016-12-17 23:48:04 PST
Attachment 297426 [details] did not pass style-queue: ERROR: Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 11 2016-12-18 00:12:53 PST
WTR fix landed in https://trac.webkit.org/r209972
Note You need to log in before you can comment on or make changes to this bug.