Bug 165968

Summary: [CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: New BugsAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, koivisto, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch kling: review+

Description Dave Hyatt 2016-12-16 12:31:23 PST 
[CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
Comment 1 Dave Hyatt 2016-12-16 12:46:23 PST 
Created attachment 297345 [details]
Patch
Comment 2 Dave Hyatt 2016-12-16 12:51:30 PST 
Created attachment 297346 [details]
Patch
Comment 3 WebKit Commit Bot 2016-12-16 12:52:59 PST 
Attachment 297346 [details] did not pass style-queue:


ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:41:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:42:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:43:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:44:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:45:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:46:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:47:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:48:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:49:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:50:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:51:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:52:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:53:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:54:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:55:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:56:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:57:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:58:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:59:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:60:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:61:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:62:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:63:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:64:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:65:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:66:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:67:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:68:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:69:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:70:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:43:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:44:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:45:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:46:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 34 in 57 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Dave Hyatt 2016-12-16 13:30:16 PST 
Created attachment 297351 [details]
Patch
Comment 5 WebKit Commit Bot 2016-12-16 13:33:19 PST 
Attachment 297351 [details] did not pass style-queue:


ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:41:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:42:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:43:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:44:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:45:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:46:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:47:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:48:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:49:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:50:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:51:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:52:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:53:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:54:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:55:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:56:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:57:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:58:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:59:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:60:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:61:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:62:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:63:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:64:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:65:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:66:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:67:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:68:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:69:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:70:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:43:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:44:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:45:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:46:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 34 in 57 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Dave Hyatt 2016-12-16 13:46:54 PST 
Created attachment 297352 [details]
Patch
Comment 7 WebKit Commit Bot 2016-12-16 13:48:46 PST 
Attachment 297352 [details] did not pass style-queue:


ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:41:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:42:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:43:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:44:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:45:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:46:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:47:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:48:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:49:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:50:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:51:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:52:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:53:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:54:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:55:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:56:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:57:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:58:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:59:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:60:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:61:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:62:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:63:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:64:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:65:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:66:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:67:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:68:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:69:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMPrimitiveValue.h:70:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMCSSValuePrivate.h"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMCSSValue.cpp"
ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:43:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:44:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:45:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/css/DeprecatedCSSOMValue.h:46:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 34 in 60 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Andreas Kling 2016-12-16 16:23:12 PST 
Comment on attachment 297352 [details]
Patch

Awesome! r=me
Comment 9 Simon Fraser (smfr) 2016-12-18 00:13:44 PST 
Link error fixed in https://trac.webkit.org/r209971
Comment 10 Simon Fraser (smfr) 2016-12-18 00:14:23 PST 
Main patch landed in https://trac.webkit.org/changeset/209969
Comment 11 Antti Koivisto 2016-12-19 08:54:37 PST 
Comment on attachment 297352 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297352&action=review

> Source/WebCore/css/DeprecatedCSSOMValue.h:86
> +    // NOTE: This class is non-virtual for memory and performance reasons.
> +    // Don't go making it virtual again unless you know exactly what you're doing!
> +    ~DeprecatedCSSOMValue() { }

These could be virtual. Only the internal types are (possibly) worth this optimization.