Bug 165960

Summary: HTML form validation bubble should be dismissed on navigation
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2016-12-16 10:56:39 PST
HTML form validation bubble should be dismissed on navigation.
Attachments
Patch (6.33 KB, patch)
2016-12-16 11:56 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (6.41 KB, patch)
2016-12-16 13:54 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-12-16 10:57:04 PST
<rdar://problem/29668086>
Chris Dumez
Comment 2 2016-12-16 11:56:13 PST
Created attachment 297338 [details] Patch
Simon Fraser (smfr)
Comment 3 2016-12-16 13:10:01 PST
Comment on attachment 297338 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297338&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:3174 > + hideValidationMessage(); Is this the right place? This happens before the rest of the page changes (which is didCommitLoad or later). > LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles.html:15 > + }, 100); 100ms is a pretty long test.
Chris Dumez
Comment 4 2016-12-16 13:11:56 PST
Comment on attachment 297338 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297338&action=review >> Source/WebKit2/UIProcess/WebPageProxy.cpp:3174 >> + hideValidationMessage(); > > Is this the right place? This happens before the rest of the page changes (which is didCommitLoad or later). Yes, this happens early in the load but I figured that there is no point showing the bubble if a navigation has been triggered, even if that load has not been committed yet. >> LayoutTests/http/tests/navigation/navigation-dismisses-validation-bubbles.html:15 >> + }, 100); > > 100ms is a pretty long test. Ok, I can shorten this before landing.
Chris Dumez
Comment 5 2016-12-16 13:54:53 PST
Created attachment 297353 [details] Patch
WebKit Commit Bot
Comment 6 2016-12-16 15:01:26 PST
Comment on attachment 297353 [details] Patch Clearing flags on attachment: 297353 Committed r209941: <http://trac.webkit.org/changeset/209941>
WebKit Commit Bot
Comment 7 2016-12-16 15:01:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.