| Summary: | i64.eqz should use an Int64 zero | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, mark.lam, msaboff, saam | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Keith Miller
2016-12-15 19:32:21 PST
Created attachment 297293 [details]
Patch
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json". Comment on attachment 297293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297293&action=review r=me with suggested change. > Source/JavaScriptCore/wasm/generateWasmOpsHeader.py:268 > +inline const char* makeString(OpType op) I think "opName" would be a better name than "makeString". Comment on attachment 297293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297293&action=review >> Source/JavaScriptCore/wasm/generateWasmOpsHeader.py:268 >> +inline const char* makeString(OpType op) > > I think "opName" would be a better name than "makeString". I chose makeString because it works with the new WasmParser.h failure template code. Comment on attachment 297293 [details] Patch Clearing flags on attachment: 297293 Committed r209923: <http://trac.webkit.org/changeset/209923> All reviewed patches have been landed. Closing bug. |