Bug 165939

Summary: Web Inspector: Modernize find banner UI
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Content browser find bar
none
[Image] Console tab find bar
none
Patch
none
[Image] before / after none

Matt Baker
Reported 2016-12-15 18:02:31 PST
Match Xcode: - Move previous / next buttons to right edge of input field - No shadow or gradient background on button press - Divider separating previous / next buttons should *not* be flush with horizontal borders, unless one of the buttons is pressed Customization for Inspector: - Retain leading results text (e.g. "3 matches"), since there is plenty of horizontal space
Attachments
[Image] Content browser find bar (36.78 KB, image/png)
2016-12-15 18:10 PST, Matt Baker 		no flags
Details
[Image] Console tab find bar (78.95 KB, image/png)
2016-12-15 18:11 PST, Matt Baker 		no flags
Details
Patch (11.16 KB, patch)
2016-12-15 18:26 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Image] before / after (171.77 KB, image/png)
2016-12-15 18:40 PST, Matt Baker 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2016-12-15 18:10:51 PST
Created attachment 297272 [details] [Image] Content browser find bar Shows button states
Matt Baker
Comment 2 2016-12-15 18:11:23 PST
Created attachment 297273 [details] [Image] Console tab find bar
Matt Baker
Comment 3 2016-12-15 18:26:03 PST
Created attachment 297278 [details] Patch
Matt Baker
Comment 4 2016-12-15 18:40:30 PST
Created attachment 297282 [details] [Image] before / after
WebKit Commit Bot
Comment 5 2016-12-16 08:56:55 PST
Comment on attachment 297278 [details] Patch Clearing flags on attachment: 297278 Committed r209921: <http://trac.webkit.org/changeset/209921>
WebKit Commit Bot
Comment 6 2016-12-16 08:56:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.