Bug 165939 - Web Inspector: Modernize find banner UI
Summary: Web Inspector: Modernize find banner UI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-15 18:02 PST by Matt Baker
Modified: 2016-12-16 08:56 PST (History)
2 users (show)

See Also:

Attachments
[Image] Content browser find bar (36.78 KB, image/png)
2016-12-15 18:10 PST, Matt Baker 		no flags Details
[Image] Console tab find bar (78.95 KB, image/png)
2016-12-15 18:11 PST, Matt Baker 		no flags Details
Patch (11.16 KB, patch)
2016-12-15 18:26 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
[Image] before / after (171.77 KB, image/png)
2016-12-15 18:40 PST, Matt Baker 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2016-12-15 18:02:31 PST 
Match Xcode:
 - Move previous / next buttons to right edge of input field
 - No shadow or gradient background on button press
 - Divider separating previous / next buttons should *not* be flush with horizontal borders, unless one of the buttons is pressed

Customization for Inspector:
 - Retain leading results text (e.g. "3 matches"), since there is plenty of horizontal space
Comment 1 Matt Baker 2016-12-15 18:10:51 PST 
Created attachment 297272 [details]
[Image] Content browser find bar

Shows button states
Comment 2 Matt Baker 2016-12-15 18:11:23 PST 
Created attachment 297273 [details]
[Image] Console tab find bar
Comment 3 Matt Baker 2016-12-15 18:26:03 PST 
Created attachment 297278 [details]
Patch
Comment 4 Matt Baker 2016-12-15 18:40:30 PST 
Created attachment 297282 [details]
[Image] before / after
Comment 5 WebKit Commit Bot 2016-12-16 08:56:55 PST 
Comment on attachment 297278 [details]
Patch

Clearing flags on attachment: 297278

Committed r209921: <http://trac.webkit.org/changeset/209921>
Comment 6 WebKit Commit Bot 2016-12-16 08:56:58 PST 
All reviewed patches have been landed.  Closing bug.