Bug 16592

Summary:

[Gtk] Launcher functionalities

Product:

WebKit

Reporter:

Luca Bruno <lethalman88>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Enhancement

CC:

christian

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
first patch	none
first patch	none
launcher patch	none
Add navigational keyboard shortcuts to GtkLauncher	none

Luca Bruno

Reported 2007-12-23 15:38:36 PST

Hello, the GtkLauncher is currently missing some important points for testing rendering and new API. Some points: - Cut/Copy/Paste clipboard API into an "Edit" menu - An Open menu item in a "File" menu for opening local files - A "Bookmarks" menu showing fixed URIs good for testing - A notebook for testing the correct behavior of multiple webviews (i.e. page-loading-related signals)

Attachments
first patch (3.85 KB, patch) 2007-12-24 07:16 PST, Luca Bruno	no flags	Details Formatted Diff Diff
first patch (3.87 KB, patch) 2007-12-24 07:19 PST, Luca Bruno	no flags	Details Formatted Diff Diff
launcher patch (6.26 KB, patch) 2008-01-07 04:47 PST, Luca Bruno	no flags	Details Formatted Diff Diff
Add navigational keyboard shortcuts to GtkLauncher (2.09 KB, patch) 2008-03-01 08:03 PST, Kalle Vahlman	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Luca Bruno

Comment 1 2007-12-24 07:16:39 PST

Created attachment 18092 [details] first patch Add "Edit" with cut/copy/paste items and "Bookmarks" menu with just 2 bookmarks.

Luca Bruno

Comment 2 2007-12-24 07:19:44 PST

Created attachment 18093 [details] first patch

Alp Toker

Comment 3 2008-01-06 14:24:51 PST

The bookmarks implementation is cute but I think we should avoid statically hard coding any more URLs into GtkLauncher. Any one else have thoughts on this? (Personally I'd like to see a menu entry to enable/disable editing, but that can be added later of course.)

Luca Bruno

Comment 4 2008-01-07 04:47:54 PST

Created attachment 18310 [details] launcher patch Add editable-mode menu item and refresh/stop tool buttons.

Alp Toker

Comment 5 2008-01-27 15:58:55 PST

Comment on attachment 18310 [details] launcher patch Clearing the review flag on this. The functionality is important but it makes GtkLauncher ugly, which is a problem since GtkLauncher is the first thing users see, appears in screenshots, magazines etc. I didn't consider how to make it look better, maybe just a matter of adding more menu entries.

Luca Bruno

Comment 6 2008-01-28 08:52:27 PST

I don't understand, what you suggest then?

Kalle Vahlman

Comment 7 2008-03-01 08:03:59 PST

Created attachment 19472 [details] Add navigational keyboard shortcuts to GtkLauncher Here's another enhancement for GtkLauncher, which might be useful for testing history items etc. and makes using the GtkLauncher slightly more pleasant to use. It adds - <Ctrl>-l for activating the url entry - <Meta>-Home for going to start page (google.com really) - <Meta>-Left for going to back in history - <Meta>-Right for going to forward in history AFAIK these should be pretty universally used shortcuts, and at least I'm basing my browser usage to those so not having them is a pain :)

Christian Dywan

Comment 8 2009-03-27 15:00:42 PDT

In my opinion this is wasted effort, making a test tool into a browser. We should rather make it easier to run Epiphany or Midori if typing it is too hard.

Gustavo Noronha (kov)

Comment 9 2009-03-27 15:06:48 PDT

These days we can test webkitgtk+ with Epiphany and Midori, so after quickly bringing this issue to the IRC channel, I am closing this bug report.

Note You need to log in before you can comment on or make changes to this bug.