Bug 16592 - [Gtk] Launcher functionalities
Summary: [Gtk] Launcher functionalities
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Enhancement
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2007-12-23 15:38 PST by Luca Bruno
Modified: 2009-03-27 15:06 PDT (History)
1 user (show)

See Also:

first patch (3.85 KB, patch)
2007-12-24 07:16 PST, Luca Bruno
no flags Details | Formatted Diff | Diff
first patch (3.87 KB, patch)
2007-12-24 07:19 PST, Luca Bruno
no flags Details | Formatted Diff | Diff
launcher patch (6.26 KB, patch)
2008-01-07 04:47 PST, Luca Bruno
no flags Details | Formatted Diff | Diff
Add navigational keyboard shortcuts to GtkLauncher (2.09 KB, patch)
2008-03-01 08:03 PST, Kalle Vahlman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luca Bruno 2007-12-23 15:38:36 PST
the GtkLauncher is currently missing some important points for testing rendering and new API. Some points:
- Cut/Copy/Paste clipboard API into an "Edit" menu
- An Open menu item in a "File" menu for opening local files
- A "Bookmarks" menu showing fixed URIs good for testing
- A notebook for testing the correct behavior of multiple webviews (i.e. page-loading-related signals)
Comment 1 Luca Bruno 2007-12-24 07:16:39 PST
Created attachment 18092 [details]
first patch

Add "Edit" with cut/copy/paste items and "Bookmarks" menu with just 2 bookmarks.
Comment 2 Luca Bruno 2007-12-24 07:19:44 PST
Created attachment 18093 [details]
first patch
Comment 3 Alp Toker 2008-01-06 14:24:51 PST
The bookmarks implementation is cute but I think we should avoid statically hard coding any more URLs into GtkLauncher. Any one else have thoughts on this?

(Personally I'd like to see a menu entry to enable/disable editing, but that can be added later of course.)
Comment 4 Luca Bruno 2008-01-07 04:47:54 PST
Created attachment 18310 [details]
launcher patch

Add editable-mode menu item and refresh/stop tool buttons.
Comment 5 Alp Toker 2008-01-27 15:58:55 PST
Comment on attachment 18310 [details]
launcher patch

Clearing the review flag on this.

The functionality is important but it makes GtkLauncher ugly, which is a problem since GtkLauncher is the first thing users see, appears in screenshots, magazines etc. I didn't consider how to make it look better, maybe just a matter of adding more menu entries.
Comment 6 Luca Bruno 2008-01-28 08:52:27 PST
I don't understand, what you suggest then?
Comment 7 Kalle Vahlman 2008-03-01 08:03:59 PST
Created attachment 19472 [details]
Add navigational keyboard shortcuts to GtkLauncher

Here's another enhancement for GtkLauncher, which might be useful for testing history items etc. and makes using the GtkLauncher slightly more pleasant to use.

It adds 
 - <Ctrl>-l for activating the url entry
 - <Meta>-Home for going to start page (google.com really)
 - <Meta>-Left for going to back in history
 - <Meta>-Right for going to forward in history

AFAIK these should be pretty universally used shortcuts, and at least I'm basing my browser usage to those so not having them is a pain :)
Comment 8 Christian Dywan 2009-03-27 15:00:42 PDT
In my opinion this is wasted effort, making a test tool into a browser. We should rather make it easier to run Epiphany or Midori if typing it is too hard.
Comment 9 Gustavo Noronha (kov) 2009-03-27 15:06:48 PDT
These days we can test webkitgtk+ with Epiphany and Midori, so after quickly bringing this issue to the IRC channel, I am closing this bug report.