Bug 165914

Summary:

Add more mach_msg logging instrumentation

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Anders Carlsson 2016-12-15 12:43:46 PST

Add more mach_msg logging instrumentation

Comment 1 Anders Carlsson 2016-12-15 12:46:18 PST

Created attachment 297212 [details]
Patch

Comment 2 Darin Adler 2016-12-15 12:50:21 PST

Comment on attachment 297212 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297212&action=review

> Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm:286
> +        WKSetCrashReportApplicationSpecificInformation((CFStringRef)[NSString stringWithFormat:@"Unhandled error code %x, message '%@'", kr, message->messageName()]);

Wish we had bridging_cast to use in places like this.

> Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm:321
> +    message->setMessageName((__bridge CFStringRef)[NSString stringWithFormat:@"%s:%s:", encoder->messageReceiverName().toString().data(), encoder->messageName().toString().data()]);

Ditto.

Comment 3 Anders Carlsson 2016-12-15 14:48:50 PST

Committed r209876: <http://trac.webkit.org/changeset/209876>