Bug 165906

Summary: Inline Document::existingAXObjectCache()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: AccessibilityAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, dbates, esprehn+autocc, kangil.han, rniwa, webkit-bug-importer
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-12-15 10:58:33 PST
Inline Document::existingAXObjectCache() to avoid paying function call cost in the common case where AX is disabled.
Attachments
Patch (3.06 KB, patch)
2016-12-15 10:59 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-12-15 10:59:48 PST
Created attachment 297202 [details] Patch
Darin Adler
Comment 2 2016-12-15 12:43:20 PST
Comment on attachment 297202 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297202&action=review > Source/WebCore/dom/Document.cpp:278 > +bool Document::hasEverCreatedAnAXObjectCache = false; I see no code in this patch setting this to true.
Darin Adler
Comment 3 2016-12-15 12:43:50 PST
Comment on attachment 297202 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297202&action=review >> Source/WebCore/dom/Document.cpp:278 >> +bool Document::hasEverCreatedAnAXObjectCache = false; > > I see no code in this patch setting this to true. Oops, I see now. The flag already existed.
WebKit Commit Bot
Comment 4 2016-12-15 13:09:16 PST
Comment on attachment 297202 [details] Patch Clearing flags on attachment: 297202 Committed r209870: <http://trac.webkit.org/changeset/209870>
WebKit Commit Bot
Comment 5 2016-12-15 13:09:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.