Bug 165903

Summary: Added missing override and final specifiers
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: WebCore Misc.Assignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, mcatanzaro
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Konstantin Tokarev
Reported 2016-12-15 10:29:18 PST
Added missing override and final specifiers as detected by clang-tidy. 'final' is used instead of override in final classes.
Attachments
Patch (81.97 KB, patch)
2016-12-15 10:31 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Patch (81.89 KB, patch)
2016-12-15 10:40 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-12-15 10:31:46 PST
Created attachment 297199 [details] Patch
Konstantin Tokarev
Comment 2 2016-12-15 10:40:47 PST
Created attachment 297200 [details] Patch
Darin Adler
Comment 3 2016-12-15 12:47:58 PST
Comment on attachment 297200 [details] Patch Another thing that would be nice to do would be marking more classes final. Lots of these classes seem to be final. Any class that has no classes deriving from it should probably get marked that way. We can always remove it later if we want to derive a class from it. And also, any function that is not overridden further could be marked final even if the class is not final.
Konstantin Tokarev
Comment 4 2016-12-15 13:26:47 PST
Comment on attachment 297200 [details] Patch Clearing flags on attachment: 297200 Committed r209871: <http://trac.webkit.org/changeset/209871>
Konstantin Tokarev
Comment 5 2016-12-15 13:26:54 PST
All reviewed patches have been landed. Closing bug.
Konstantin Tokarev
Comment 6 2016-12-15 13:33:25 PST
Yes, but such changes require more careful attitude, and have more potential of breaking build for some untested ports, so it's better to do them separately step by step
Note You need to log in before you can comment on or make changes to this bug.