Summary: | [EFL] Disable non-srcdir builds for failing libraries | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hunseop Jeong <hs85.jeong> | ||||
Component: | WebKit EFL | Assignee: | Hunseop Jeong <hs85.jeong> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, gyuyoung.kim, lucas.de.marchi | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Hunseop Jeong
2016-12-15 01:55:02 PST
Created attachment 297187 [details]
Patch
[GTK][EFL] Update the JHBuild version. http://trac.webkit.org/changeset/209804 Comment on attachment 297187 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297187&action=review > Tools/ChangeLog:8 > + * efl/jhbuild.modules: Set non srcdir builds to no Is it fine to skip the build of non-src directory modules ? Shouldn't we find proper directory ? (In reply to comment #3) > Comment on attachment 297187 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=297187&action=review > > > Tools/ChangeLog:8 > > + * efl/jhbuild.modules: Set non srcdir builds to no > > Is it fine to skip the build of non-src directory modules ? Shouldn't we > find proper directory ? I tested it and it worked fine. If we didn't set the non-src builds to no, 'update-webkitefl-libs' failed to build the libraies. Anyway I will check one more to find the proper directory. Comment on attachment 297187 [details]
Patch
Ok, please land it after checking it one more time.
Comment on attachment 297187 [details] Patch Clearing flags on attachment: 297187 Committed r209918: <http://trac.webkit.org/changeset/209918> All reviewed patches have been landed. Closing bug. |