Bug 165882

Summary: DirectTailCall implementation needs to tell the shuffler what to put into the ArgumentCount explicitly
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, keith_miller, mark.lam, msaboff, rniwa, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch mark.lam: review+

Filip Pizlo
Reported 2016-12-14 17:03:25 PST
Patch forthcoming.
Attachments
the patch (9.91 KB, patch)
2016-12-14 17:09 PST, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-12-14 17:09:39 PST
Created attachment 297147 [details] the patch
Mark Lam
Comment 2 2016-12-14 17:23:48 PST
Comment on attachment 297147 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=297147&action=review LGTM. > Source/WTF/wtf/Platform.h:893 > -#if (CPU(X86) || CPU(X86_64) || CPU(ARM64) || (CPU(ARM_THUMB2) && PLATFORM(IOS))) && ENABLE(JIT) && OS(DARWIN) && !defined(NDEBUG) > +#if (CPU(X86) || CPU(X86_64) || CPU(ARM64) || (CPU(ARM_THUMB2) && PLATFORM(IOS))) && ENABLE(JIT) && OS(DARWIN) I presume this was not deliberate but leftover from a debugging session? If so, please undo.
Filip Pizlo
Comment 3 2016-12-14 17:24:39 PST
(In reply to comment #2) > Comment on attachment 297147 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=297147&action=review > > LGTM. > > > Source/WTF/wtf/Platform.h:893 > > -#if (CPU(X86) || CPU(X86_64) || CPU(ARM64) || (CPU(ARM_THUMB2) && PLATFORM(IOS))) && ENABLE(JIT) && OS(DARWIN) && !defined(NDEBUG) > > +#if (CPU(X86) || CPU(X86_64) || CPU(ARM64) || (CPU(ARM_THUMB2) && PLATFORM(IOS))) && ENABLE(JIT) && OS(DARWIN) > > I presume this was not deliberate but leftover from a debugging session? If > so, please undo. Will do!
Filip Pizlo
Comment 4 2016-12-14 17:26:12 PST
Landed in https://trac.webkit.org/changeset/209846
Alexey Proskuryakov
Comment 5 2017-01-03 14:21:00 PST
*** Bug 166642 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.