Bug 165875
| Summary: | ScriptFunctionCall::call() can return an empty JSValue if the watchdog timer fires, callers should check for this | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Saboff <msaboff> |
| Component: | JavaScriptCore | Assignee: | Yury Semikhatsky <yurys> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer, yurys |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Michael Saboff
Many callers of ScriptFunctionCall::call() assume that it returns a valid, non-empty JSValue. Most of these callers do not check for this. They should be fixed as appropriate.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Saboff
rdar://problem/29671015
Yury Semikhatsky
We've crashes due to an empty value on Windows around this call in particular https://github.com/WebKit/WebKit/blob/020f297aadfe1e55b3d238dfc7922cfa193ceae3/Source/JavaScriptCore/inspector/InjectedScript.cpp#L292 in Playwright.
Yury Semikhatsky
Pull request: https://github.com/WebKit/WebKit/pull/20353
EWS
Committed 270739@main (a4eed62b176c): <https://commits.webkit.org/270739@main>
Reviewed commits have been landed. Closing PR #20353 and removing active labels.