Bug 165807

Summary: Small refactor: Use HashCountedSet rather than HashMap<..., int> to store client counts in WebPlaybackSessionManager{,Proxy}.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jeremyj-wk, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for landing
none
Patch none

Description Jer Noble 2016-12-13 10:29:50 PST
Small refactor: Use HashCountedSet rather than HashMap<..., int> to store client counts in WebPlaybackSessionManager{,Proxy}.
Comment 1 Jer Noble 2016-12-13 10:33:05 PST
Created attachment 297021 [details]
Patch for landing
Comment 2 Jer Noble 2016-12-13 10:41:48 PST
Created attachment 297024 [details]
Patch
Comment 3 Eric Carlson 2016-12-16 13:02:58 PST
Comment on attachment 297024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297024&action=review

> Source/WebKit2/UIProcess/Cocoa/WebPlaybackSessionManagerProxy.h:37
>  #include <wtf/HashSet.h>

Nit: you can probably delete this.
Comment 4 Jer Noble 2016-12-16 13:37:47 PST
Comment on attachment 297024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297024&action=review

>> Source/WebKit2/UIProcess/Cocoa/WebPlaybackSessionManagerProxy.h:37
>>  #include <wtf/HashSet.h>
> 
> Nit: you can probably delete this.

Unfortunately, there's another HashMap member and another HashSet member in this file.
Comment 5 WebKit Commit Bot 2016-12-16 14:06:32 PST
Comment on attachment 297024 [details]
Patch

Clearing flags on attachment: 297024

Committed r209937: <http://trac.webkit.org/changeset/209937>
Comment 6 WebKit Commit Bot 2016-12-16 14:06:36 PST
All reviewed patches have been landed.  Closing bug.