Bug 165807

Summary: Small refactor: Use HashCountedSet rather than HashMap<..., int> to store client counts in WebPlaybackSessionManager{,Proxy}.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jeremyj-wk, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for landing
none
Patch none

Jer Noble
Reported 2016-12-13 10:29:50 PST
Small refactor: Use HashCountedSet rather than HashMap<..., int> to store client counts in WebPlaybackSessionManager{,Proxy}.
Attachments
Patch for landing (7.25 KB, patch)
2016-12-13 10:33 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (5.81 KB, patch)
2016-12-13 10:41 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2016-12-13 10:33:05 PST
Created attachment 297021 [details] Patch for landing
Jer Noble
Comment 2 2016-12-13 10:41:48 PST
Created attachment 297024 [details] Patch
Eric Carlson
Comment 3 2016-12-16 13:02:58 PST
Comment on attachment 297024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297024&action=review > Source/WebKit2/UIProcess/Cocoa/WebPlaybackSessionManagerProxy.h:37 > #include <wtf/HashSet.h> Nit: you can probably delete this.
Jer Noble
Comment 4 2016-12-16 13:37:47 PST
Comment on attachment 297024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297024&action=review >> Source/WebKit2/UIProcess/Cocoa/WebPlaybackSessionManagerProxy.h:37 >> #include <wtf/HashSet.h> > > Nit: you can probably delete this. Unfortunately, there's another HashMap member and another HashSet member in this file.
WebKit Commit Bot
Comment 5 2016-12-16 14:06:32 PST
Comment on attachment 297024 [details] Patch Clearing flags on attachment: 297024 Committed r209937: <http://trac.webkit.org/changeset/209937>
WebKit Commit Bot
Comment 6 2016-12-16 14:06:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.