Bug 165802

Summary: IndexedDB 2.0: Massively speedup IDBIndex.get()
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, commit-queue, jsbell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 165803    
Bug Blocks: 160306    
Attachments:
Description Flags
Patch none

Brady Eidson
Reported 2016-12-13 09:53:45 PST
IndexedDB 2.0: Don't use a cursor internally for IDBIndex.get() I put together a perf test that benchmarks IDBIndex.get(), and using a cursor to do it was extremely hot in profiles.
Attachments
Patch (41.26 KB, patch)
2016-12-14 11:41 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-12-13 09:56:42 PST
I'm going to try to land the test first and give the bots at least 1 cycle on it, so we have a record of the speedup.
Brady Eidson
Comment 2 2016-12-14 11:41:27 PST
Created attachment 297107 [details] Patch
Brady Eidson
Comment 3 2016-12-14 11:57:43 PST
<rdar://problem/29666094>
WebKit Commit Bot
Comment 4 2016-12-14 12:57:26 PST
Comment on attachment 297107 [details] Patch Clearing flags on attachment: 297107 Committed r209824: <http://trac.webkit.org/changeset/209824>
WebKit Commit Bot
Comment 5 2016-12-14 12:57:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.