Bug 165787

Summary:

[WebIDL] Remove use of Dictionary in ApplePaySession

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, esprehn+autocc, kondapallykalyan, manian, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=169639

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-yosemite	none
Archive of layout-test-results from ews106 for mac-yosemite-wk2	none
Archive of layout-test-results from ews112 for mac-yosemite	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Patch	andersca: review+

Sam Weinig

Reported 2016-12-12 18:41:19 PST

[WebIDL] Remove use of Dictionary in ApplePaySession

Attachments
Patch (118.28 KB, patch) 2016-12-12 18:55 PST, Sam Weinig	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-yosemite (955.74 KB, application/zip) 2016-12-12 20:02 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (953.66 KB, application/zip) 2016-12-12 20:06 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews112 for mac-yosemite (1.68 MB, application/zip) 2016-12-12 20:08 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (deleted) 2016-12-12 20:27 PST, Build Bot	no flags	Details
Patch (119.64 KB, patch) 2016-12-13 10:03 PST, Sam Weinig	andersca: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2016-12-12 18:55:01 PST

Created attachment 296979 [details] Patch

Sam Weinig

Comment 2 2016-12-12 18:55:39 PST

I probably need to disable the new test directory on platforms that don't support ApplePay.

WebKit Commit Bot

Comment 3 2016-12-12 18:57:09 PST

Attachment 296979 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:176: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 4 2016-12-12 20:02:54 PST

Comment on attachment 296979 [details] Patch Attachment 296979 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2709520 New failing tests: http/tests/ssl/applepay/ApplePaySession.html

Build Bot

Comment 5 2016-12-12 20:02:58 PST

Created attachment 296985 [details] Archive of layout-test-results from ews100 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 6 2016-12-12 20:06:52 PST

Comment on attachment 296979 [details] Patch Attachment 296979 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2709531 New failing tests: http/tests/ssl/applepay/ApplePaySession.html

Build Bot

Comment 7 2016-12-12 20:06:57 PST

Created attachment 296986 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 8 2016-12-12 20:08:40 PST

Comment on attachment 296979 [details] Patch Attachment 296979 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2709516 New failing tests: http/tests/ssl/applepay/ApplePaySession.html

Build Bot

Comment 9 2016-12-12 20:08:44 PST

Created attachment 296987 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 10 2016-12-12 20:27:29 PST

Comment on attachment 296979 [details] Patch Attachment 296979 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2709557 New failing tests: http/tests/ssl/applepay/ApplePaySession.html

Build Bot

Comment 11 2016-12-12 20:27:34 PST

Created attachment 296988 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Sam Weinig

Comment 12 2016-12-13 10:03:14 PST

Created attachment 297018 [details] Patch

WebKit Commit Bot

Comment 13 2016-12-13 10:06:15 PST

Attachment 297018 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/applepay/ApplePaySession.h:176: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 14 2016-12-13 10:22:26 PST

Comment on attachment 297018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297018&action=review > Source/WebCore/Modules/applepay/ApplePaySession.cpp:300 > + // FIXME: Should this swallow exceptions like the old code seemed to do? I don't think so!

Sam Weinig

Comment 15 2016-12-13 10:47:34 PST

Committed r209760: <http://trac.webkit.org/changeset/209760>

Radar WebKit Bug Importer

Comment 16 2017-03-03 10:30:00 PST

<rdar://problem/30835075>

Note You need to log in before you can comment on or make changes to this bug.