| Summary: | Add Document.onvisibilitychange event handler attribute | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, dbates, esprehn+autocc, igrigorik, kangil.han, kondapallykalyan | ||||||
| Priority: | P2 | Keywords: | WebExposed | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| URL: | http://w3c.github.io/page-visibility/#onvisiblitychange-event-handler | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2016-12-12 16:48:26 PST
Created attachment 296968 [details]
Patch
Comment on attachment 296968 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296968&action=review > LayoutTests/fast/events/page-visibility-onvisibilitychange.html:1 > +<html> Please add <!DOCTYPE html> to the top of this file as I do not see the need to use quirks mode for this test. > LayoutTests/fast/events/page-visibility-onvisibilitychange.html:2 > +<body onload='startTest()'> We are underutilizing the purpose of the onload attribute given that the startTest() is defined in a script inside <body>. I suggest that we call startTest() above </script> and then remove the onload attribute from this line. Created attachment 296971 [details]
Patch
Comment on attachment 296971 [details] Patch Clearing flags on attachment: 296971 Committed r209750: <http://trac.webkit.org/changeset/209750> All reviewed patches have been landed. Closing bug. *** Bug 174177 has been marked as a duplicate of this bug. *** |