Bug 165778

Summary: Drop unnecessary null check in removeDetachedChildrenInContainer()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, dbates, esprehn+autocc, kangil.han, koivisto, rniwa, sam, wenson_hsieh
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Attempt to fix OpenSource iOS builds none

Chris Dumez
Reported 2016-12-12 15:03:53 PST
Drop unnecessary null check in removeDetachedChildrenInContainer(). Node cannot be null but we do an implicit null check.
Attachments
Patch (1.53 KB, patch)
2016-12-12 15:04 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Attempt to fix OpenSource iOS builds (63.12 KB, text/plain)
2016-12-13 20:55 PST, Wenson Hsieh 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-12-12 15:04:59 PST
Created attachment 296955 [details] Patch
WebKit Commit Bot
Comment 2 2016-12-12 18:21:31 PST
Comment on attachment 296955 [details] Patch Clearing flags on attachment: 296955 Committed r209751: <http://trac.webkit.org/changeset/209751>
WebKit Commit Bot
Comment 3 2016-12-12 18:21:36 PST
All reviewed patches have been landed. Closing bug.
Wenson Hsieh
Comment 4 2016-12-13 20:55:03 PST
Reopening to attach new patch.
Wenson Hsieh
Comment 5 2016-12-13 20:55:06 PST
Created attachment 297063 [details] Attempt to fix OpenSource iOS builds
Wenson Hsieh
Comment 6 2016-12-13 20:55:59 PST
My bad, accidentally reopened this when uploading a patch :/ Closing again.
Note You need to log in before you can comment on or make changes to this bug.