Bug 165771

Summary: [CSS Parser] MediaQueryParser should use Ref and not RefPtr
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: New BugsAssignee: Dave Hyatt <hyatt>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: barraclough, commit-queue, ntim
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Dave Hyatt
Reported 2016-12-12 13:10:59 PST
[CSS Parser] MediaQueryParser should use Ref and not RefPtr
Attachments
Patch (6.18 KB, patch)
2016-12-12 13:11 PST, Dave Hyatt 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2016-12-12 13:11:58 PST
Created attachment 296946 [details] Patch
WebKit Commit Bot
Comment 2 2016-12-12 13:13:49 PST
Attachment 296946 [details] did not pass style-queue: ERROR: Source/WebCore/css/parser/MediaQueryParser.h:92: 'parseInternal' is incorrectly named. It should be named 'protector' or 'protectedCSSParserTokenRange'. [readability/naming/protected] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 3 2016-12-12 13:50:35 PST
Fixed in r209726.
Gavin Barraclough
Comment 4 2016-12-14 00:26:01 PST
Rolled out in r209794 due to memory regression in r209726.
Tim Nguyen (:ntim)
Comment 5 2023-05-02 13:14:44 PDT
The media query code has since been rewritten
Note You need to log in before you can comment on or make changes to this bug.