Bug 165745

Summary: Web Inspector: Cleanup HierarchicalPathComponent
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Matt Baker 2016-12-11 18:16:20 PST 
Modernize and tidy up code, remove single use CSS class name constants, and back all properties by the model not the DOM.
Comment 1 Matt Baker 2016-12-11 18:23:54 PST 
Created attachment 296888 [details]
Patch
Comment 2 Blaze Burg 2016-12-12 09:22:13 PST 
Comment on attachment 296888 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2016-12-12 09:24:36 PST 
Comment on attachment 296888 [details]
Patch

Clearing flags on attachment: 296888

Committed r209711: <http://trac.webkit.org/changeset/209711>
Comment 4 WebKit Commit Bot 2016-12-12 09:24:39 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Joseph Pecoraro 2016-12-12 10:16:21 PST 
Comment on attachment 296888 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296888&action=review

> Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js:96
> +    get element() { return this._element; }
> +    get representedObject() { return this._representedObject; }

I still think we shouldn't have one line getters/setters in the middle of a list of getters/setters. I think they should be at the top.
Comment 6 Blaze Burg 2016-12-12 10:18:43 PST 
(In reply to comment #5)
> Comment on attachment 296888 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=296888&action=review
> 
> > Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.js:96
> > +    get element() { return this._element; }
> > +    get representedObject() { return this._representedObject; }
> 
> I still think we shouldn't have one line getters/setters in the middle of a
> list of getters/setters. I think they should be at the top.

I am indifferent. Can you update the style guide if it's not in there already?