Bug 165715

Summary: WebAssembly: implement the elements section
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, oliver, ticaiolima, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
WIP
none
patch keith_miller: review+

Saam Barati
Reported 2016-12-09 20:23:55 PST
...
Attachments
WIP (8.42 KB, patch)
2016-12-13 14:28 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
WIP (12.72 KB, patch)
2016-12-13 15:12 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (19.08 KB, patch)
2016-12-13 16:05 PST, Saam Barati 		keith_miller: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2016-12-13 12:34:00 PST
Will work on this now.
Saam Barati
Comment 2 2016-12-13 14:28:32 PST
Created attachment 297041 [details] WIP it begins
Saam Barati
Comment 3 2016-12-13 15:12:48 PST
Created attachment 297045 [details] WIP This might be the patch. Need to start writing tests.
Saam Barati
Comment 4 2016-12-13 16:05:07 PST
Created attachment 297047 [details] patch
WebKit Commit Bot
Comment 5 2016-12-13 16:07:25 PST
Attachment 297047 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/WasmModuleParser.cpp:509: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Keith Miller
Comment 6 2016-12-13 16:47:07 PST
Comment on attachment 297047 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=297047&action=review r=me. > Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp:229 > + return throwException(state, scope, createRangeError(state, > + ASCIILiteral("Element is trying to set an out of bounds table index"))); Why not just throwVMRangeError()? Unless you want to build a string with the indices seems like we should just use the simpler syntax. > Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp:239 > + ASCIILiteral("Element is setting the table value with an import. This is not yet implemented. FIXME:"))); Did you mean to link to a bug here?
Saam Barati
Comment 7 2016-12-13 17:20:19 PST
Comment on attachment 297047 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=297047&action=review >> Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp:229 >> + ASCIILiteral("Element is trying to set an out of bounds table index"))); > > Why not just throwVMRangeError()? Unless you want to build a string with the indices seems like we should just use the simpler syntax. Yeah sounds good. >> Source/JavaScriptCore/wasm/js/WebAssemblyModuleRecord.cpp:239 >> + ASCIILiteral("Element is setting the table value with an import. This is not yet implemented. FIXME:"))); > > Did you mean to link to a bug here? Yeah. I'll do that.
Saam Barati
Comment 8 2016-12-13 17:32:49 PST
landed in: https://trac.webkit.org/changeset/209785
Note You need to log in before you can comment on or make changes to this bug.