|Summary:||Web Inspector: Move MainTarget and WorkerTarget to their own files|
|Product:||WebKit||Reporter:||Joseph Pecoraro <joepeck>|
|Component:||Web Inspector||Assignee:||Joseph Pecoraro <joepeck>|
|Severity:||Normal||CC:||bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer|
|Version:||WebKit Nightly Build|
Description Joseph Pecoraro 2016-12-09 16:22:59 PST
Summary: Move MainTarget and WorkerTarget to their own files This is cleanup that I had in another patch that is stalled. Separating it out into its own patch.
Comment 1 Joseph Pecoraro 2016-12-09 16:27:14 PST
Created attachment 296737 [details] [PATCH] Proposed Fix
Comment 2 BJ Burg 2016-12-11 15:12:30 PST
Comment on attachment 296737 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=296737&action=review rs=me > Source/WebInspectorUI/UserInterface/Protocol/Target.js:-147 > - initialize() Why did this construction ever exist instead of putting in just one subclass constructor?
Comment 3 WebKit Commit Bot 2016-12-11 15:37:43 PST
Comment on attachment 296737 [details] [PATCH] Proposed Fix Clearing flags on attachment: 296737 Committed r209686: <http://trac.webkit.org/changeset/209686>
Comment 4 WebKit Commit Bot 2016-12-11 15:37:48 PST
All reviewed patches have been landed. Closing bug.