Bug 165688

Summary: Web Inspector: Cleanup some InspectorInstrumentation network loading notifications
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, cdumez, commit-queue, dbates, japhet, joepeck, mattbaker, mkwst, nvasilyev, timothy, webkit-bug-importer, youennf
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2016-12-09 14:48:32 PST
Summary: Cleanup some InspectorInstrumentation network loading notifications There is a lot of code that does: InspectorInstrumentationCookie cookie = InspectorInstrumentation::willReceiveResourceResponse(&m_frame); InspectorInstrumentation::didReceiveResourceResponse(cookie, identifier, loader, r, resourceLoader); In which case the will* call that produces a cookie is entirely unnecessary. Simplify this code and related code.
Attachments
[PATCH] Proposed Fix (18.83 KB, patch)
2016-12-09 16:11 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-12-09 16:11:46 PST
Created attachment 296732 [details] [PATCH] Proposed Fix
Blaze Burg
Comment 2 2016-12-11 15:14:41 PST
Comment on attachment 296732 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 3 2016-12-11 15:40:48 PST
Comment on attachment 296732 [details] [PATCH] Proposed Fix Clearing flags on attachment: 296732 Committed r209687: <http://trac.webkit.org/changeset/209687>
WebKit Commit Bot
Comment 4 2016-12-11 15:40:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.