Bug 165685

Summary: Ignore LayoutTests/imported/w3c/web-platform-tests/config.json
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Tools / TestsAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, joepeck, lforschler, rniwa, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
rniwa: review+
[PATCH] For Landing none

Joseph Pecoraro
Reported 2016-12-09 14:38:35 PST
Ignore LayoutTests/imported/w3c/web-platform-tests/config.json I get this file when I run: $ run-webkit-tests --debug LayoutTests/imported It seems to include user specific data, for instance a path to my Build Directory: $ cat LayoutTests/imported/w3c/web-platform-tests/config.json | grep pecoraro "base_path": "/Users/pecoraro/Build/Debug/layout-test-results/_wpt_certs", So it looks like it shouldn't be committed. I suggest ignoring it so it doesn't commonly show up as an untracked file.
Attachments
[PATCH] Proposed Fix (1.15 KB, patch)
2016-12-09 14:39 PST, Joseph Pecoraro 		rniwa: review+
DetailsFormatted DiffDiff
[PATCH] For Landing (1.15 KB, patch)
2016-12-09 16:29 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-12-09 14:39:21 PST
Created attachment 296702 [details] [PATCH] Proposed Fix
Ryosuke Niwa
Comment 2 2016-12-09 14:45:27 PST
Comment on attachment 296702 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=296702&action=review > LayoutTests/imported/w3c/web-platform-tests/.gitignore:1 > +config.json We should probably do /config.json instead since we could have some other config.json in a subdirectory we want to check in.
Joseph Pecoraro
Comment 3 2016-12-09 16:29:39 PST
Created attachment 296738 [details] [PATCH] For Landing
WebKit Commit Bot
Comment 4 2016-12-09 19:07:31 PST
Comment on attachment 296738 [details] [PATCH] For Landing Clearing flags on attachment: 296738 Committed r209645: <http://trac.webkit.org/changeset/209645>
Note You need to log in before you can comment on or make changes to this bug.