Bug 165678

Summary: TextPosition and OrdinalNumber should be more like idiomatic numbers
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch fpizlo: review+

Geoffrey Garen
Reported 2016-12-09 13:36:01 PST
TextPosition and OrdinalNumber should be more like idiomatic numbers
Attachments
Patch (22.80 KB, patch)
2016-12-09 13:41 PST, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (23.71 KB, patch)
2016-12-09 13:57 PST, Geoffrey Garen 		fpizlo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2016-12-09 13:41:38 PST
Created attachment 296689 [details] Patch
Mark Lam
Comment 2 2016-12-09 13:55:05 PST
Comment on attachment 296689 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296689&action=review > Source/WebCore/xml/XMLErrors.cpp:63 > + if (type == fatal || (m_errorCount < maxErrors && !(m_lastErrorPosition || (m_lastErrorPosition->m_line != position.m_line && m_lastErrorPosition->m_column != position.m_column)))) { Shouldn't this be (!m_lastErrorPosition || (m_lastErrorPosition->... ?
Geoffrey Garen
Comment 3 2016-12-09 13:56:10 PST
> > Source/WebCore/xml/XMLErrors.cpp:63 > > + if (type == fatal || (m_errorCount < maxErrors && !(m_lastErrorPosition || (m_lastErrorPosition->m_line != position.m_line && m_lastErrorPosition->m_column != position.m_column)))) { > > Shouldn't this be (!m_lastErrorPosition || (m_lastErrorPosition->... ? Oops! Yup.
Geoffrey Garen
Comment 4 2016-12-09 13:57:17 PST
Created attachment 296693 [details] Patch
Geoffrey Garen
Comment 5 2016-12-09 14:04:43 PST
Committed r209627: <http://trac.webkit.org/changeset/209627>
Note You need to log in before you can comment on or make changes to this bug.