Bug 165677

Summary: Web Inspector: Update CodeMirror to support async/await keyword and other ES2017 features
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix bburg: review+

Joseph Pecoraro
Reported 2016-12-09 13:18:42 PST
Summary: Update CodeMirror to support async/await keyword and other ES2017 features Support for new ES2017 features in JavaScript was added in June-August: https://github.com/codemirror/CodeMirror/issues/4085 https://github.com/codemirror/CodeMirror/issues/4152 All of these seem useful / relevant: > cbbd941 [javascript mode] Improve handling of async in object literal > b3482bb [javascript mode] Fix a bug in parsing of arrow function with no args > 5e29ee6 [javascript mode] Fix bug in array literal parsing > 31eb1b2 [javascript mode] Handle trailing commas better > 2319665 [javascript mode] Improve support for async keyword > b2c1116 [javascript mode] Support async and await > 0d73c4b [javascript mode] Allow trailing comma in object destructure This would highlight the keywords and potentially improve other syntax highlighting surrounding new syntax.
Attachments
[PATCH] Proposed Fix (808.25 KB, patch)
2016-12-19 15:43 PST, Joseph Pecoraro 		bburg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2016-12-19 15:43:15 PST
Created attachment 297485 [details] [PATCH] Proposed Fix Tested viewing resources, styles sidebar, syntax highlighting of JavaScript/CSS/HTML, pretty printing, inline markers (errors/warnings), breakpoints, and some other general testing.
Radar WebKit Bug Importer
Comment 2 2016-12-19 16:38:09 PST
<rdar://problem/29744608>
Blaze Burg
Comment 3 2016-12-20 11:16:27 PST
Comment on attachment 297485 [details] [PATCH] Proposed Fix rs=me
Joseph Pecoraro
Comment 4 2016-12-20 13:42:27 PST
https://trac.webkit.org/changeset/210032
Note You need to log in before you can comment on or make changes to this bug.