Bug 165677 - Web Inspector: Update CodeMirror to support async/await keyword and other ES2017 features
Summary: Web Inspector: Update CodeMirror to support async/await keyword and other ES2...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-09 13:18 PST by Joseph Pecoraro
Modified: 2016-12-20 13:42 PST (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (808.25 KB, patch)
2016-12-19 15:43 PST, Joseph Pecoraro 		bburg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-12-09 13:18:42 PST 
Summary:
Update CodeMirror to support async/await keyword and other ES2017 features

Support for new ES2017 features in JavaScript was added in June-August:
https://github.com/codemirror/CodeMirror/issues/4085
https://github.com/codemirror/CodeMirror/issues/4152

All of these seem useful / relevant:
> cbbd941 [javascript mode] Improve handling of async in object literal
> b3482bb [javascript mode] Fix a bug in parsing of arrow function with no args
> 5e29ee6 [javascript mode] Fix bug in array literal parsing
> 31eb1b2 [javascript mode] Handle trailing commas better
> 2319665 [javascript mode] Improve support for async keyword
> b2c1116 [javascript mode] Support async and await
> 0d73c4b [javascript mode] Allow trailing comma in object destructure

This would highlight the keywords and potentially improve other syntax highlighting surrounding new syntax.
Comment 1 Joseph Pecoraro 2016-12-19 15:43:15 PST 
Created attachment 297485 [details]
[PATCH] Proposed Fix

Tested viewing resources, styles sidebar, syntax highlighting of JavaScript/CSS/HTML, pretty printing, inline markers (errors/warnings), breakpoints, and some other general testing.
Comment 2 Radar WebKit Bug Importer 2016-12-19 16:38:09 PST 
<rdar://problem/29744608>
Comment 3 BJ Burg 2016-12-20 11:16:27 PST 
Comment on attachment 297485 [details]
[PATCH] Proposed Fix

rs=me
Comment 4 Joseph Pecoraro 2016-12-20 13:42:27 PST 
https://trac.webkit.org/changeset/210032